Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reading from stdin should broadcast EOF to block loaders #409

Merged
merged 2 commits into from
Apr 6, 2023
Merged

fix: reading from stdin should broadcast EOF to block loaders #409

merged 2 commits into from
Apr 6, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Apr 5, 2023

otherwise results in a blocking wait when you do an extract-all but there are missing blocks that you're waiting for a "done" signal for.

@rvagg
fix: reading from stdin should broadcast EOF to block loaders
2670bb8 
otherwise results in a blocking wait when you do an extract-all but there are
missing blocks that you're waiting for a "done" signal for.
@rvagg
Copy link
Member Author

rvagg commented Apr 5, 2023

Ref: https://github.com/filecoin-project/filecoin-docs/pull/1812/files#r1151300008

@rvagg rvagg mentioned this pull request Apr 5, 2023
Merged
4 tasks
@rvagg
Copy link
Member Author

rvagg commented Apr 5, 2023

Also note that --verbose now only writes to stderr, I'm considering that a fix.

@rvagg rvagg merged commit b1b0477 into master Apr 6, 2023
@rvagg rvagg deleted the rvagg/broadcast-eof-stdin branch April 6, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

@masih masih Awaiting requested review from masih masih is a code owner

@hannahhoward hannahhoward Awaiting requested review from hannahhoward hannahhoward is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvagg @willscott