Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header error tests #76

Merged
merged 3 commits into from
Jun 3, 2021
Merged

Header error tests #76

merged 3 commits into from
Jun 3, 2021

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 3, 2021

Also pulls in #74 and #75

Ref: ipld/js-car#28

Also included in this is an explicit check for 0aa16776657273696f6e02 (<length>{version:2}) as per ipld/specs#248 (comment) so it can be used as a CARv2 escape - if we end up using this string as a modifier for CARv2 we can at least get proper errors out of this if it encounters a newer format.

the primary difference with js-car is that go-car requires a non-empty roots array whereas js-car is fine with empty roots array, hence the test fixture differences

@rvagg rvagg requested review from masih and mvdan June 3, 2021 09:07
@mvdan
Copy link
Contributor

mvdan commented Jun 3, 2021

Hm, why not merge #75 first? otherwise the review gets tricky :)

Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure on the order of PRs that are open. If this pulls other PRs in, would it make sense to close the other ones?

Left a bunch of questions.
LGTM 🍻

car_test.go Show resolved Hide resolved
.github/workflows/automerge.yml Outdated Show resolved Hide resolved
.github/workflows/automerge.yml Outdated Show resolved Hide resolved
Ref: ipld/js-car#28

the primary difference with js-car is that go-car requires a non-empty roots
array whereas js-car is fine with empty roots array, hence the test fixture
differences
@rvagg
Copy link
Member Author

rvagg commented Jun 3, 2021

okie dokie, this is much simpler to review now, just the relevant changes and some .gitignore action

car_test.go Show resolved Hide resolved
@rvagg rvagg mentioned this pull request Jun 3, 2021
@rvagg rvagg merged commit dce5390 into master Jun 3, 2021
@rvagg rvagg deleted the rvagg/header-errors branch June 3, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants