fix: check header object and reject invalid headers & versions #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
added a commit
to ipld/go-car
that referenced
this pull request
Jun 3, 2021
Ref: ipld/js-car#28 the primary difference with js-car is that go-car requires a non-empty roots array whereas js-car is fine with empty roots array, hence the test fixture differences
rvagg
added a commit
to ipld/go-car
that referenced
this pull request
Jun 3, 2021
Ref: ipld/js-car#28 the primary difference with js-car is that go-car requires a non-empty roots array whereas js-car is fine with empty roots array, hence the test fixture differences
rvagg
added a commit
to ipld/go-car
that referenced
this pull request
Jun 3, 2021
Ref: ipld/js-car#28 the primary difference with js-car is that go-car requires a non-empty roots array whereas js-car is fine with empty roots array, hence the test fixture differences
Jorropo
pushed a commit
to ipfs/boxo
that referenced
this pull request
Mar 22, 2023
Ref: ipld/js-car#28 the primary difference with js-car is that go-car requires a non-empty roots array whereas js-car is fine with empty roots array, hence the test fixture differences This commit was moved from ipld/go-car@2876c18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version doesn't really check the header object is valid and it doesn't look at the version, but it should be strict, as per spec.
Also included in this is an explicit check for
0aa16776657273696f6e02(<length>{version:2}) as per ipld/specs#248 (comment) so it can be used as a CARv2 escape - if we end up using this string as a modifier for CARv2 we can at least get proper errors out of this if it encounters a newer format.Doing this as a semver-patch since we're within spec and I doubt there are any CARs out there without a proper
{version:1, roots:[...]}header.