Enable Lint Rule: unused-receiver (#5521)

## Which problem is this PR solving?
-  Partial Fix for #5506

## Description of the changes
- Enabled unused-receiver in revive linter
- Removed receiver names which are not used in functions 

## How was this change tested?
- `make lint` `make test`

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>

.golangci.yml

@@ -171,9 +171,6 @@ linters-settings:
         # do a clean-up and enable
         - name: unused-parameter
           disabled: true
-        # do a clean-up and enable
-        - name: unused-receiver
-          disabled: true
         # we use storage_v2, so...
         - name: var-naming
           disabled: true

cmd/agent/app/builder_test.go

@@ -182,11 +182,11 @@ func TestMultipleCollectorProxies(t *testing.T) {
 
 type fakeCollectorProxy struct{}
 
-func (f fakeCollectorProxy) GetReporter() reporter.Reporter {
+func (fakeCollectorProxy) GetReporter() reporter.Reporter {
 	return fakeCollectorProxy{}
 }
 
-func (f fakeCollectorProxy) GetManager() configmanager.ClientConfigManager {
+func (fakeCollectorProxy) GetManager() configmanager.ClientConfigManager {
 	return fakeCollectorProxy{}
 }
 
@@ -202,7 +202,7 @@ func (fakeCollectorProxy) Close() error {
 	return nil
 }
 
-func (f fakeCollectorProxy) GetSamplingStrategy(_ context.Context, _ string) (*api_v2.SamplingStrategyResponse, error) {
+func (fakeCollectorProxy) GetSamplingStrategy(_ context.Context, _ string) (*api_v2.SamplingStrategyResponse, error) {
 	return nil, errors.New("no peers available")
 }
 

cmd/agent/app/configmanager/grpc/manager.go

@@ -47,6 +47,6 @@ func (s *ConfigManagerProxy) GetSamplingStrategy(ctx context.Context, serviceNam
 }
 
 // GetBaggageRestrictions returns baggage restrictions from collector.
-func (s *ConfigManagerProxy) GetBaggageRestrictions(_ context.Context, _ string) ([]*baggage.BaggageRestriction, error) {
+func (*ConfigManagerProxy) GetBaggageRestrictions(_ context.Context, _ string) ([]*baggage.BaggageRestriction, error) {
 	return nil, errors.New("baggage not implemented")
 }

cmd/agent/app/customtransport/buffered_read_transport.go

@@ -36,19 +36,19 @@ func NewTBufferedReadTransport(readBuf *bytes.Buffer) (*TBufferedReadTransport,
 
 // IsOpen does nothing as transport is not maintaining the connection
 // Required to maintain thrift.TTransport interface
-func (p *TBufferedReadTransport) IsOpen() bool {
+func (*TBufferedReadTransport) IsOpen() bool {
 	return true
 }
 
 // Open does nothing as transport is not maintaining the connection
 // Required to maintain thrift.TTransport interface
-func (p *TBufferedReadTransport) Open() error {
+func (*TBufferedReadTransport) Open() error {
 	return nil
 }
 
 // Close does nothing as transport is not maintaining the connection
 // Required to maintain thrift.TTransport interface
-func (p *TBufferedReadTransport) Close() error {
+func (*TBufferedReadTransport) Close() error {
 	return nil
 }
 
@@ -72,6 +72,6 @@ func (p *TBufferedReadTransport) Write(buf []byte) (int, error) {
 
 // Flush does nothing as udp server does not write responses back
 // Required to maintain thrift.TTransport interface
-func (p *TBufferedReadTransport) Flush(_ context.Context) error {
+func (*TBufferedReadTransport) Flush(_ context.Context) error {
 	return nil
 }

cmd/agent/app/reporter/grpc/reporter_test.go

@@ -183,7 +183,7 @@ func TestReporter_MakeModelKeyValue(t *testing.T) {
 
 type mockMultitenantSpanHandler struct{}
 
-func (h *mockMultitenantSpanHandler) PostSpans(ctx context.Context, r *api_v2.PostSpansRequest) (*api_v2.PostSpansResponse, error) {
+func (*mockMultitenantSpanHandler) PostSpans(ctx context.Context, r *api_v2.PostSpansRequest) (*api_v2.PostSpansResponse, error) {
 	md, ok := metadata.FromIncomingContext(ctx)
 	if !ok {
 		return &api_v2.PostSpansResponse{}, status.Errorf(codes.PermissionDenied, "missing tenant header")

cmd/agent/app/servers/tbuffered_server_test.go

@@ -117,7 +117,7 @@ func (t *fakeTransport) Read(p []byte) (n int, err error) {
 	return len(p), nil
 }
 
-func (t *fakeTransport) Close() error {
+func (*fakeTransport) Close() error {
 	return nil
 }
 

cmd/agent/app/servers/thriftudp/transport.go

@@ -93,7 +93,7 @@ func NewTUDPServerTransport(hostPort string) (*TUDPTransport, error) {
 
 // Open does nothing as connection is opened on creation
 // Required to maintain thrift.TTransport interface
-func (p *TUDPTransport) Open() error {
+func (*TUDPTransport) Open() error {
 	return nil
 }
 
@@ -131,7 +131,7 @@ func (p *TUDPTransport) Read(buf []byte) (int, error) {
 
 // RemainingBytes returns the max number of bytes (same as Thrift's StreamTransport) as we
 // do not know how many bytes we have left.
-func (p *TUDPTransport) RemainingBytes() uint64 {
+func (*TUDPTransport) RemainingBytes() uint64 {
 	const maxSize = ^uint64(0)
 	return maxSize
 }

cmd/collector/app/collector.go

@@ -169,7 +169,7 @@ func (c *Collector) Start(options *flags.CollectorOptions) error {
 	return nil
 }
 
-func (c *Collector) publishOpts(cOpts *flags.CollectorOptions) {
+func (*Collector) publishOpts(cOpts *flags.CollectorOptions) {
 	safeexpvar.SetInt(metricNumWorkers, int64(cOpts.NumWorkers))
 	safeexpvar.SetInt(metricQueueSize, int64(cOpts.QueueSize))
 }

cmd/collector/app/collector_test.go

@@ -61,7 +61,7 @@ func (t *mockAggregator) HandleRootSpan(span *model.Span, logger *zap.Logger) {
 	t.callCount.Add(1)
 }
 
-func (t *mockAggregator) Start() {}
+func (*mockAggregator) Start() {}
 
 func (t *mockAggregator) Close() error {
 	t.closeCount.Add(1)
@@ -146,11 +146,11 @@ func TestCollector_StartErrors(t *testing.T) {
 
 type mockStrategyStore struct{}
 
-func (m *mockStrategyStore) GetSamplingStrategy(_ context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error) {
+func (*mockStrategyStore) GetSamplingStrategy(_ context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error) {
 	return &api_v2.SamplingStrategyResponse{}, nil
 }
 
-func (m *mockStrategyStore) Close() error {
+func (*mockStrategyStore) Close() error {
 	return nil
 }
 

cmd/collector/app/handler/grpc_handler_test.go

@@ -91,7 +91,7 @@ func (p *mockSpanProcessor) reset() {
 	p.spanFormat = ""
 }
 
-func (p *mockSpanProcessor) Close() error {
+func (*mockSpanProcessor) Close() error {
 	return nil
 }
 

cmd/collector/app/handler/http_thrift_handler_test.go

@@ -171,7 +171,7 @@ func TestCannotReadBodyFromRequest(t *testing.T) {
 
 type errReader struct{}
 
-func (e *errReader) Read(p []byte) (int, error) {
+func (*errReader) Read(p []byte) (int, error) {
 	return 0, fmt.Errorf("Simulated error reading body")
 }
 
@@ -180,7 +180,7 @@ type dummyResponseWriter struct {
 	myStatusCode int
 }
 
-func (d *dummyResponseWriter) Header() http.Header {
+func (*dummyResponseWriter) Header() http.Header {
 	return http.Header{}
 }
 

cmd/collector/app/handler/thrift_span_handler_test.go

@@ -80,7 +80,7 @@ func (s *shouldIErrorProcessor) ProcessSpans(mSpans []*model.Span, _ processor.S
 	return retMe, nil
 }
 
-func (s *shouldIErrorProcessor) Close() error {
+func (*shouldIErrorProcessor) Close() error {
 	return nil
 }
 

cmd/collector/app/options.go

@@ -172,7 +172,7 @@ func (options) OnDroppedSpan(onDroppedSpan func(span *model.Span)) Option {
 	}
 }
 
-func (o options) apply(opts ...Option) options {
+func (options) apply(opts ...Option) options {
 	ret := options{}
 	for _, opt := range opts {
 		opt(&ret)

cmd/collector/app/sampling/grpc_handler_test.go

@@ -28,7 +28,7 @@ import (
 
 type mockSamplingStore struct{}
 
-func (s mockSamplingStore) GetSamplingStrategy(ctx context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error) {
+func (mockSamplingStore) GetSamplingStrategy(ctx context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error) {
 	if serviceName == "error" {
 		return nil, errors.New("some error")
 	} else if serviceName == "nil" {
@@ -37,7 +37,7 @@ func (s mockSamplingStore) GetSamplingStrategy(ctx context.Context, serviceName
 	return &api_v2.SamplingStrategyResponse{StrategyType: api_v2.SamplingStrategyType_PROBABILISTIC}, nil
 }
 
-func (s mockSamplingStore) Close() error {
+func (mockSamplingStore) Close() error {
 	return nil
 }
 

cmd/collector/app/sanitizer/cache/auto_refresh_cache.go

@@ -65,7 +65,7 @@ func (c *autoRefreshCache) Get(key string) string {
 }
 
 // Put implementation that does nothing
-func (c *autoRefreshCache) Put(key string, value string) error {
+func (*autoRefreshCache) Put(key string, value string) error {
 	return nil
 }
 

cmd/collector/app/sanitizer/service_name_sanitizer_test.go

@@ -40,11 +40,11 @@ func (d *fixedMappingCache) Get(key string) string {
 	return k
 }
 
-func (d *fixedMappingCache) Put(key string, value string) error {
+func (*fixedMappingCache) Put(key string, value string) error {
 	return nil
 }
 
-func (d *fixedMappingCache) Initialize() error {
+func (*fixedMappingCache) Initialize() error {
 	return nil
 }
 

cmd/collector/app/sanitizer/zipkin/span_sanitizer.go

@@ -69,7 +69,7 @@ func NewSpanDurationSanitizer() Sanitizer {
 
 type spanDurationSanitizer struct{}
 
-func (s *spanDurationSanitizer) Sanitize(span *zc.Span) *zc.Span {
+func (*spanDurationSanitizer) Sanitize(span *zc.Span) *zc.Span {
 	if span.Duration == nil {
 		duration := defaultDuration
 		if len(span.Annotations) >= 2 {
@@ -116,7 +116,7 @@ func NewSpanStartTimeSanitizer() Sanitizer {
 
 type spanStartTimeSanitizer struct{}
 
-func (s *spanStartTimeSanitizer) Sanitize(span *zc.Span) *zc.Span {
+func (*spanStartTimeSanitizer) Sanitize(span *zc.Span) *zc.Span {
 	if span.Timestamp != nil || len(span.Annotations) == 0 {
 		return span
 	}
@@ -143,7 +143,7 @@ func NewParentIDSanitizer() Sanitizer {
 
 type parentIDSanitizer struct{}
 
-func (s *parentIDSanitizer) Sanitize(span *zc.Span) *zc.Span {
+func (*parentIDSanitizer) Sanitize(span *zc.Span) *zc.Span {
 	if span.ParentID == nil || *span.ParentID != 0 {
 		return span
 	}
@@ -166,7 +166,7 @@ func NewErrorTagSanitizer() Sanitizer {
 
 type errorTagSanitizer struct{}
 
-func (s *errorTagSanitizer) Sanitize(span *zc.Span) *zc.Span {
+func (*errorTagSanitizer) Sanitize(span *zc.Span) *zc.Span {
 	for _, binAnno := range span.BinaryAnnotations {
 		if binAnno.AnnotationType != zc.AnnotationType_BOOL && strings.EqualFold("error", binAnno.Key) {
 			binAnno.AnnotationType = zc.AnnotationType_BOOL

cmd/collector/app/server/test.go

@@ -24,20 +24,20 @@ import (
 
 type mockSamplingStore struct{}
 
-func (s mockSamplingStore) GetSamplingStrategy(_ context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error) {
+func (mockSamplingStore) GetSamplingStrategy(_ context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error) {
 	return nil, nil
 }
 
-func (s mockSamplingStore) Close() error {
+func (mockSamplingStore) Close() error {
 	return nil
 }
 
 type mockSpanProcessor struct{}
 
-func (p *mockSpanProcessor) Close() error {
+func (*mockSpanProcessor) Close() error {
 	return nil
 }
 
-func (p *mockSpanProcessor) ProcessSpans(spans []*model.Span, _ processor.SpansOptions) ([]bool, error) {
+func (*mockSpanProcessor) ProcessSpans(spans []*model.Span, _ processor.SpansOptions) ([]bool, error) {
 	return []bool{}, nil
 }

cmd/collector/app/span_processor_test.go

@@ -197,7 +197,7 @@ func (n *fakeSpanWriter) WriteSpan(ctx context.Context, span *model.Span) error
 	return n.err
 }
 
-func (n *fakeSpanWriter) Close() error {
+func (*fakeSpanWriter) Close() error {
 	return nil
 }
 

cmd/es-index-cleaner/app/flags.go

@@ -43,7 +43,7 @@ type Config struct {
 }
 
 // AddFlags adds flags for TLS to the FlagSet.
-func (c *Config) AddFlags(flags *flag.FlagSet) {
+func (*Config) AddFlags(flags *flag.FlagSet) {
 	flags.String(indexPrefix, "", "Index prefix")
 	flags.Bool(archive, false, "Whether to remove archive indices. It works only for rollover")
 	flags.Bool(rollover, false, "Whether to remove indices created by rollover")

cmd/es-rollover/app/init/flags.go

@@ -43,7 +43,7 @@ type Config struct {
 }
 
 // AddFlags adds flags for TLS to the FlagSet.
-func (c *Config) AddFlags(flags *flag.FlagSet) {
+func (*Config) AddFlags(flags *flag.FlagSet) {
 	flags.Int(shards, 5, "Number of shards")
 	flags.Int(replicas, 1, "Number of replicas")
 	flags.Int(prioritySpanTemplate, 0, "Priority of jaeger-span index template (ESv8 only)")

cmd/es-rollover/app/lookback/flags.go

@@ -37,7 +37,7 @@ type Config struct {
 }
 
 // AddFlags adds flags for TLS to the FlagSet.
-func (c *Config) AddFlags(flags *flag.FlagSet) {
+func (*Config) AddFlags(flags *flag.FlagSet) {
 	flags.String(unit, defaultUnit, "used with lookback to remove indices from read alias e.g, days, weeks, months, years")
 	flags.Int(unitCount, defaultUnitCount, "count of UNITs")
 }

cmd/es-rollover/app/rollover/flags.go

@@ -34,7 +34,7 @@ type Config struct {
 }
 
 // AddFlags adds flags for TLS to the FlagSet.
-func (c *Config) AddFlags(flags *flag.FlagSet) {
+func (*Config) AddFlags(flags *flag.FlagSet) {
 	flags.String(conditions, defaultRollbackCondition, "conditions used to rollover to a new write index")
 }
 

cmd/ingester/app/consumer/committing_processor_test.go

@@ -65,7 +65,7 @@ func TestNewCommittingProcessorError(t *testing.T) {
 
 type fakeProcessorMessage struct{}
 
-func (f fakeProcessorMessage) Value() []byte {
+func (fakeProcessorMessage) Value() []byte {
 	return nil
 }
 

cmd/ingester/app/consumer/processor_factory_test.go

@@ -91,7 +91,7 @@ func (f *fakeProcessor) Start() {
 
 type fakeMsg struct{}
 
-func (f *fakeMsg) Value() []byte {
+func (*fakeMsg) Value() []byte {
 	return nil
 }
 

cmd/ingester/app/processor/decorator/retry_test.go

@@ -95,7 +95,7 @@ func TestNewRetryingProcessorNoErrorPropagation(t *testing.T) {
 
 type fakeRand struct{}
 
-func (f *fakeRand) Int63n(v int64) int64 {
+func (*fakeRand) Int63n(v int64) int64 {
 	return v
 }
 

cmd/jaeger/internal/exporters/storageexporter/exporter.go

@@ -43,7 +43,7 @@ func (exp *storageExporter) start(_ context.Context, host component.Host) error
 	return nil
 }
 
-func (exp *storageExporter) close(_ context.Context) error {
+func (*storageExporter) close(_ context.Context) error {
 	// span writer is not closable
 	return nil
 }

cmd/jaeger/internal/extension/jaegerquery/server.go

@@ -42,7 +42,7 @@ func newServer(config *Config, otel component.TelemetrySettings) *server {
 }
 
 // Dependencies implements extension.Dependent to ensure this always starts after jaegerstorage extension.
-func (s *server) Dependencies() []component.ID {
+func (*server) Dependencies() []component.ID {
 	return []component.ID{jaegerstorage.ID}
 }