Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Lint Rule: unused-receiver #5521

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

FlamingSaint
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Enabled unused-receiver in revive linter
  • Removed receiver names which are not used in functions

How was this change tested?

  • make lint make test

Checklist

Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@FlamingSaint FlamingSaint requested a review from a team as a code owner June 3, 2024 15:58
@FlamingSaint FlamingSaint requested a review from jkowall June 3, 2024 15:58
@FlamingSaint
Copy link
Member Author

I removed the receiver name itself instead of using ( _ ) . Is that okay ?

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 97.08029% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.19%. Comparing base (f2b46d4) to head (2b28f91).
Report is 5 commits behind head on main.

Files Patch % Lines
cmd/collector/app/server/test.go 25.00% 3 Missing ⚠️
pkg/discovery/grpcresolver/grpc_resolver.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5521      +/-   ##
==========================================
- Coverage   96.19%   96.19%   -0.01%     
==========================================
  Files         327      327              
  Lines       16012    16011       -1     
==========================================
- Hits        15403    15401       -2     
  Misses        435      435              
- Partials      174      175       +1     
Flag Coverage Δ
badger_v1 8.05% <8.97%> (+<0.01%) ⬆️
badger_v2 1.93% <5.19%> (+<0.01%) ⬆️
cassandra-3.x-v1 16.43% <14.10%> (+<0.01%) ⬆️
cassandra-3.x-v2 1.85% <5.19%> (+<0.01%) ⬆️
cassandra-4.x-v1 16.43% <14.10%> (+<0.01%) ⬆️
cassandra-4.x-v2 1.85% <5.19%> (+<0.01%) ⬆️
elasticsearch-7-v1 18.88% <19.23%> (-0.01%) ⬇️
elasticsearch-8-v1 19.07% <19.23%> (-0.01%) ⬇️
elasticsearch-8-v2 19.08% <19.23%> (+<0.01%) ⬆️
grpc_v1 9.48% <11.53%> (+<0.01%) ⬆️
grpc_v2 7.53% <10.38%> (+<0.01%) ⬆️
kafka 9.78% <6.41%> (+<0.01%) ⬆️
opensearch-1-v1 18.93% <19.23%> (-0.01%) ⬇️
opensearch-2-v1 18.94% <19.23%> (+<0.01%) ⬆️
opensearch-2-v2 18.94% <19.23%> (+<0.01%) ⬆️
unittests 93.88% <97.08%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 3, 2024
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@yurishkuro yurishkuro merged commit f56409c into jaegertracing:main Jun 3, 2024
40 of 41 checks passed
@FlamingSaint FlamingSaint deleted the linter_rule_1 branch June 3, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants