We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug system architecture and deep dependency graph return empty result while data exists in ES. does the function 'createDependencyReader' in 'https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/es/factory.go' forget to init IndexDateLayout ?
current:
reader := esDepStore.NewDependencyStore(esDepStore.DependencyStoreParams{ Client: client, Logger: logger, IndexPrefix: cfg.GetIndexPrefix(), MaxDocCount: cfg.GetMaxDocCount(), UseReadWriteAliases: cfg.GetUseReadWriteAliases(), })
may should be:
reader := esDepStore.NewDependencyStore(esDepStore.DependencyStoreParams{ Client: client, Logger: logger, IndexPrefix: cfg.GetIndexPrefix(), MaxDocCount: cfg.GetMaxDocCount(), UseReadWriteAliases: cfg.GetUseReadWriteAliases(), IndexDateLayout: cfg.GetIndexDateLayoutDependencies(), })
add this
IndexDateLayout: cfg.GetIndexDateLayoutDependencies(),
to make sure
func indexWithDate(indexNamePrefix, indexDateLayout string, date time.Time) string { return indexNamePrefix + date.UTC().Format(indexDateLayout) }
from https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/es/dependencystore/storage.go not alway return a empty string
which effect DependencyStore.GetDependencies can only search 'jaeger-dependencies-' not 'jaeger-dependencies-2022-02-08'
The text was updated successfully, but these errors were encountered:
i test the diff in my local environment, and it seems works
Sorry, something went wrong.
@galric got hit by this also - with the same conclusion.
fix indexDateLayout for elasticsearch dependencies jaegertracing#3523
c70db35
cc14933
Signed-off-by: ilya morgenshtern <ilya.m@coralogix.com>
fix indexDateLayout for elasticsearch dependencies #3523 (#3524)
0b700b8
Signed-off-by: ilya morgenshtern <ilya.m@coralogix.com> Co-authored-by: Albert <26584478+albertteoh@users.noreply.github.com>
Seems to be fixed per #3524
No branches or pull requests
Describe the bug
system architecture and deep dependency graph return empty result while data exists in ES.
does the function 'createDependencyReader' in 'https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/es/factory.go' forget to init IndexDateLayout ?
current:
may should be:
add this
to make sure
from https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/es/dependencystore/storage.go
not alway return a empty string
which effect DependencyStore.GetDependencies can only search 'jaeger-dependencies-' not 'jaeger-dependencies-2022-02-08'
The text was updated successfully, but these errors were encountered: