-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix indexDateLayout for elasticsearch dependencies #3523 #3524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @ilyamor, could you please sign off your work
Signed-off-by: ilya morgenshtern <ilya.m@coralogix.com>
Codecov Report
@@ Coverage Diff @@
## main #3524 +/- ##
==========================================
- Coverage 96.53% 96.47% -0.06%
==========================================
Files 262 262
Lines 15337 15338 +1
==========================================
- Hits 14805 14798 -7
- Misses 451 456 +5
- Partials 81 84 +3
Continue to review full report at Codecov.
|
@@ -218,6 +218,7 @@ func createDependencyReader( | |||
Client: client, | |||
Logger: logger, | |||
IndexPrefix: cfg.GetIndexPrefix(), | |||
IndexDateLayout: cfg.GetIndexDateLayoutDependencies(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this, I wonder if we can update the unit tests to prevent this from happening again. Maybe via a type assertion of the returned dependencystore.Reader
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I find it useful, looks like a dummy test
No description provided.