Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Improvement of OpenSSF Scorecard Score #5815

Open
2 of 5 tasks
harshitasao opened this issue Aug 7, 2024 · 2 comments
Open
2 of 5 tasks

[Feature]: Improvement of OpenSSF Scorecard Score #5815

harshitasao opened this issue Aug 7, 2024 · 2 comments

Comments

@harshitasao
Copy link
Contributor

harshitasao commented Aug 7, 2024

Requirement

Hi, I'm Harshita. I’m working with CNCF and the Google Open Source Security Team for the GSoC 2024 term. We are collaborating to enhance security practices across various CNCF projects. The goal is to improve security for all CNCF projects by both using OpenSSF Scorecards and implementing its security improvements.

Problem

As this project already has scorecard action, I'm here to increase the final score by going over each check. I've listed all of the checks where work needs to be done, in order of its criticality. I plan to submit each PR for each fix. Please let me know what you think and for which ones a PR is welcome that I will submit it ASAP.

Proposal

Current Score: 8.1

Scorecard report: https://scorecard.dev/viewer/?uri=github.com/jaegertracing/jaeger

Here's a few checks we can work on to improve the project's security posture:

  • Token-Permissions: Score = 0

    • The issue here is that this workflow doesn’t have a top-level read-only permissions block like present in the other workflows. Scorecard is quite severe in this check: a single workflow without top-level permissions gets a 0/10 for the check.
    • PR: Pin GitHub Actions dependencies #5860
  • Signed-Releases: Score = 8

  • Vulnerabilities: Score = 9

    • Affected package: github.com/aws/aws-sdk-go (https://osv.dev/vulnerability/GO-2022-0646) (Already fixed)
    • May need to add an osv-scanner.toml to mark some of these as not impacting/ignored.
    • Open vulnerabilities are easily exploited by attackers and should be fixed as soon as possible.
  • Pinned-Dependencies: Score = 6

    • Some github actions and container image in Dockerfile are not pinned by hash, which is resulting in a low score. But pinning container images would introduce the risk of outdated images.
    • Pinning dependencies to a specific hash rather than allowing mutable versions or ranges of versions improves supply chain security.
    • PR: Pin GitHub Actions dependencies #5860
  • Fuzzing: Score = 0

    • Integrating the project with OSS-Fuzz by following the instructions here. The most difficult one on the list, maintainers help, is highly appreciated.
    • See Comment

/cc @joycebrum @diogoteles08 @pnacht @nate-double-u

Open questions

No response

@yurishkuro
Copy link
Member

@harshitasao thank you for assistance. I have no objection to these items, except for fuzzing.

@harshitasao
Copy link
Contributor Author

Sure, I will make the PRs ASAP.

yurishkuro pushed a commit that referenced this issue Aug 18, 2024
## Which problem is this PR solving?
fixed the pinned dependencies issue reported by
[scorecard](https://scorecard.dev/viewer/?uri=github.com/jaegertracing/jaeger).
Part of  #5815 

## Description of the changes
- pinned the github actions by hash.

## How was this change tested?
- 

## Checklist
- [X] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [X] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: harshitasao <harshitasao@gmail.com>
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this issue Aug 28, 2024
## Which problem is this PR solving?
fixed the pinned dependencies issue reported by
[scorecard](https://scorecard.dev/viewer/?uri=github.com/jaegertracing/jaeger).
Part of  jaegertracing#5815

## Description of the changes
- pinned the github actions by hash.

## How was this change tested?
-

## Checklist
- [X] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [X] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: harshitasao <harshitasao@gmail.com>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants