Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define contents permissions on "dependabot validate" workflow #5874

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Aug 22, 2024

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 requested a review from a team as a code owner August 22, 2024 07:34
@mmorel-35 mmorel-35 requested a review from jkowall August 22, 2024 07:34
Comment on lines +10 to +11
permissions:
contents: read
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it only check the json-schema for dependabot.yml, this level of permission shall be sufficient

@harshitasao, would you confirm ?

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Aug 22, 2024
@yurishkuro yurishkuro merged commit 8f2543c into jaegertracing:main Aug 22, 2024
44 checks passed
@mmorel-35 mmorel-35 deleted the patch-1 branch August 22, 2024 13:08
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.79%. Comparing base (49114db) to head (21e4d09).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5874   +/-   ##
=======================================
  Coverage   96.79%   96.79%           
=======================================
  Files         342      342           
  Lines       16525    16525           
=======================================
  Hits        15996    15996           
  Misses        341      341           
  Partials      188      188           
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.81% <ø> (ø)
cassandra-3.x-v1 16.61% <ø> (ø)
cassandra-3.x-v2 1.74% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.74% <ø> (ø)
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.84% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.03% <ø> (ø)
elasticsearch-8.x-v2 1.80% <ø> (-0.02%) ⬇️
grpc_v1 9.52% <ø> (ø)
grpc_v2 7.14% <ø> (ø)
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.81% <ø> (ø)
memory_v2 1.80% <ø> (-0.02%) ⬇️
opensearch-1.x-v1 18.88% <ø> (ø)
opensearch-2.x-v1 18.89% <ø> (ø)
opensearch-2.x-v2 1.80% <ø> (-0.02%) ⬇️
unittests 95.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 28, 2024
mahadzaryab1 pushed a commit to mahadzaryab1/jaeger that referenced this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants