Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate HotROD proto #5040

Merged
merged 6 commits into from
Dec 26, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Dec 26, 2023

Which problem is this PR solving?

  • HotROD Proto was not checked for being up to date in the standard CI check
  • And it did not match the output of the generator

Description of the changes

  • Include proto-hotrod in the main proto target so that it always runs and is checked for being up to date
  • Change settings to exclude all *.pb.go files from linting and formatting
  • Remove unnecessary wrapper script for checking license headers
  • Remove unnecessary wrapper script for checking imports order
  • Do not exclude doc.go from linting
    • Add empty tests to 3 packages that started to get tested now because of sole doc.go file

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner December 26, 2023 00:18
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Dec 26, 2023
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a798e25) 52.59% compared to head (0494bc7) 95.58%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5040       +/-   ##
===========================================
+ Coverage   52.59%   95.58%   +42.98%     
===========================================
  Files         145      319      +174     
  Lines        8599    18794    +10195     
===========================================
+ Hits         4523    17965    +13442     
+ Misses       3728      665     -3063     
+ Partials      348      164      -184     
Flag Coverage Δ
cassandra-3.x 25.61% <ø> (ø)
cassandra-4.x 25.61% <ø> (ø)
elasticsearch-5.x 19.88% <ø> (ø)
elasticsearch-6.x 19.87% <ø> (-0.02%) ⬇️
elasticsearch-7.x 20.00% <ø> (-0.02%) ⬇️
elasticsearch-8.x 20.11% <ø> (ø)
grpc-badger 19.50% <ø> (ø)
kafka 14.10% <ø> (ø)
opensearch-1.x 20.02% <ø> (ø)
opensearch-2.x 20.02% <ø> (ø)
unittests 93.33% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

proto: proto-model \
proto-api-v2 \
proto-storage-v1 \
proto-hotrod \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@yurishkuro yurishkuro requested review from albertteoh and removed request for joe-elliott December 26, 2023 03:08
@yurishkuro yurishkuro merged commit 82dd29a into jaegertracing:main Dec 26, 2023
37 checks passed
@yurishkuro yurishkuro deleted the regenerate-hotrod-proto branch December 26, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants