Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate HotROD proto #5040

Merged
merged 6 commits into from
Dec 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,10 @@ endif

# All .go files that are not auto-generated and should be auto-formatted and linted.
ALL_SRC = $(shell find . -name '*.go' \
-not -name 'doc.go' \
-not -name '_*' \
-not -name '.*' \
-not -name 'mocks*' \
-not -name 'model.pb.go' \
-not -name 'model_test.pb.go' \
-not -name 'storage_test.pb.go' \
-not -name '*.pb.go' \
-not -path './vendor/*' \
-not -path '*/mocks/*' \
-not -path '*/*-gen/*' \
Expand Down Expand Up @@ -166,18 +163,20 @@ goleak:

.PHONY: fmt
fmt:
./scripts/import-order-cleanup.sh inplace
@echo Running import-order-cleanup on ALL_SRC ...
@./scripts/import-order-cleanup.py -o inplace -t $(ALL_SRC)
@echo Running gofmt on ALL_SRC ...
@$(GOFMT) -e -s -l -w $(ALL_SRC)
@echo Running gofumpt on ALL_SRC ...
@$(GOFUMPT) -e -l -w $(ALL_SRC)
./scripts/updateLicenses.sh
@echo Running updateLicense.py on ALL_SRC ...
@./scripts/updateLicense.py $(ALL_SRC)

.PHONY: lint
lint: goleak
golangci-lint -v run
./scripts/updateLicenses.sh > $(FMT_LOG)
./scripts/import-order-cleanup.sh stdout > $(IMPORT_LOG)
@./scripts/updateLicense.py $(ALL_SRC) > $(FMT_LOG)
@./scripts/import-order-cleanup.py -o stdout -t $(ALL_SRC) > $(IMPORT_LOG)
@[ ! -s "$(FMT_LOG)" -a ! -s "$(IMPORT_LOG)" ] || (echo "License check or import ordering failures, run 'make fmt'" | cat - $(FMT_LOG) $(IMPORT_LOG) && false)
./scripts/check-semconv-version.sh
./scripts/check-go-version.sh
Expand Down
9 changes: 8 additions & 1 deletion Makefile.Protobuf.mk
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,14 @@ endef

# TODO add proto-hotrod to the list after regenerating its file (may need linter tweaking)
.PHONY: proto
proto: proto-model proto-api-v2 proto-storage-v1 proto-zipkin proto-openmetrics proto-otel proto-api-v3
proto: proto-model \
proto-api-v2 \
proto-storage-v1 \
proto-hotrod \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

proto-zipkin \
proto-openmetrics \
proto-otel \
proto-api-v3

.PHONY: proto-model
proto-model:
Expand Down
59 changes: 17 additions & 42 deletions examples/hotrod/services/driver/driver.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 30 additions & 0 deletions model/converter/empty_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// Copyright (c) 2020 The Jaeger Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package converter

import (
"testing"

"go.uber.org/goleak"
)

func TestDummy(t *testing.T) {
// This is a dummy test in the root package.
// Without it `go test -v .` prints "testing: warning: no tests to run".
}

func TestMain(m *testing.M) {
goleak.VerifyTestMain(m)
}
30 changes: 30 additions & 0 deletions model/converter/thrift/empty_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// Copyright (c) 2020 The Jaeger Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package thrift

import (
"testing"

"go.uber.org/goleak"
)

func TestDummy(t *testing.T) {
// This is a dummy test in the root package.
// Without it `go test -v .` prints "testing: warning: no tests to run".
}

func TestMain(m *testing.M) {
goleak.VerifyTestMain(m)
}
30 changes: 30 additions & 0 deletions pkg/empty_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// Copyright (c) 2020 The Jaeger Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package pkg

import (
"testing"

"go.uber.org/goleak"
)

func TestDummy(t *testing.T) {
// This is a dummy test in the root package.
// Without it `go test -v .` prints "testing: warning: no tests to run".
}

func TestMain(m *testing.M) {
goleak.VerifyTestMain(m)
}
15 changes: 0 additions & 15 deletions scripts/import-order-cleanup.sh

This file was deleted.

15 changes: 0 additions & 15 deletions scripts/updateLicenses.sh

This file was deleted.