[hotrod] Fix connectivity in docker compose #5734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5734 +/- ##
=======================================
Coverage 96.84% 96.84%
=======================================
Files 335 335
Lines 16155 16155
=======================================
Hits 15645 15645
Misses 340 340
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Jul 12, 2024
yurishkuro
added a commit
that referenced
this pull request
Jul 13, 2024
## Which problem is this PR solving? - Resolves #5737 ## Description of the changes - Revert #5734 - Default OTLP receiver endpoints to `:port` instead of relying on OTEL Collector defaults - Clean up tests to use ephemeral ports when possible ## How was this change tested? - Tested similar to #5734 by using `COLLECTOR_OTLP_HTTP_HOST_PORT=:4318` --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
localhost. However, that does not work inside a Docker container (at least on MacOS & Docker Desktop).Description of the changes
0.0.0.0)How was this change tested?