Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OTLP receiver listen on all IPs again #5739

Merged
merged 10 commits into from
Jul 13, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jul 12, 2024

Which problem is this PR solving?

Description of the changes

How was this change tested?

Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.84%. Comparing base (eae8e66) to head (a517dc8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5739   +/-   ##
=======================================
  Coverage   96.84%   96.84%           
=======================================
  Files         335      335           
  Lines       16155    16166   +11     
=======================================
+ Hits        15645    15656   +11     
  Misses        340      340           
  Partials      170      170           
Flag Coverage Δ
badger_v1 8.06% <ø> (ø)
badger_v2 1.90% <ø> (ø)
cassandra-3.x-v1 16.62% <ø> (ø)
cassandra-3.x-v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.62% <ø> (ø)
cassandra-4.x-v2 1.82% <ø> (ø)
elasticsearch-6.x-v1 18.79% <ø> (-0.02%) ⬇️
elasticsearch-7.x-v1 18.86% <ø> (ø)
elasticsearch-8.x-v1 19.05% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v2 1.89% <ø> (ø)
grpc_v1 9.46% <ø> (+0.01%) ⬆️
grpc_v2 7.41% <ø> (ø)
kafka 9.75% <ø> (ø)
opensearch-1.x-v1 18.91% <ø> (ø)
opensearch-2.x-v1 18.91% <ø> (+0.01%) ⬆️
opensearch-2.x-v2 1.89% <ø> (ø)
unittests 95.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link
Contributor

@afzal442 afzal442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing the listening challenges.

@yurishkuro yurishkuro merged commit a54e2a5 into jaegertracing:main Jul 13, 2024
42 checks passed
@yurishkuro yurishkuro deleted the all-ips branch July 13, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Jaeger v1.59 doesn't accept OpenTelemetry data on ports 4317/4318
3 participants