feat: Add support for creating PullRequests.

[bigkevmcd]

This adds support for creating a PullRequest with title, body branch references in the GitHub and GitLab drivers.

The fake driver records created PullRequestInput records.

The other drivers return NotSupported errors.

[jenkins-x-bot]

Hi @bigkevmcd. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jstrachan]

/ok-to-test

[jstrachan]

/lgtm

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abayer]

@bigkevmcd Sorry to bug you, but have you actually tested the PR creation on gitlab? I have a sinking feeling it won't do anything -

go-scm/scm/driver/gitlab/gitlab.go

Line 58 in 6796482

func (c *wrapper) do(ctx context.Context, method, path string, in, out interface{}) (*scm.Response, error) {

doesn't actually pass in to the request, which...yeah, that'll be a problem. =) I'll play around with it on #68, where I'm adding updating PRs, but I think we need to do something more like

go-scm/scm/driver/gitlab/issue.go

Lines 83 to 85 in b82884a

	in.Set("title", input.Title)
	in.Set("description", input.Body)
	path := fmt.Sprintf("api/v4/projects/%s/issues?%s", encode(repo), in.Encode())

.

I'm legitimately not sure why we're encoding as parameters rather than just passing as data with application/json in general for Gitlab, but if that works, it's fine by me. =)

[bigkevmcd]

@abayer sorry, I was travelling last week.

I tested the GitHub version, but alas, I didn't test the GitLab one, and naively assumed that the tests would cover it, dunno why I didn't test it given that it was a 2 line change to run the code against GitLab, and yes, it responds with a 400.

I'm happy to rework the implementation to convert to JSON, which is what it should be doing, yes.

[abayer]

No worries! I'm traveling this week, so my responses won't be timely either. =) I've started reworking the gl web hook stuff completely - no rush on the GL api side from my perspective. It feels like a lot of the GL code was copied loosely from somewhere else without fully implementing everything, let alone testing it, so I don't expect this is gonna be speedy.

[abayer]

Oh, and at least it's not BitBucket. Sigh.