Create pr when PR number is empty on output

[bigkevmcd]

Changes

This changes the pullrequest resource to allow it to create PRs during the upload.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sbwsg
You can assign the PR to them by writing /assign @sbwsg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bigkevmcd]

This is for early feedback, I'd like to refactor the client that the Handler uses in the pullrequest package, so that the errPullService can be reduced.

Also, should the process for creating new PRs be more explicit?

maybe a new_pr.json file?

[ghost]

Thanks for the PR. Just so you are aware - pipeline resources are going through a major redesign at the moment and aren't being promoted into the upcoming beta.

It's still totally fine to commit code to the existing pipeline resources but their usage and structure may change quite a lot over the coming months.

@bigkevmcd I noticed that you're using a forked version of go-scm here. Are you upstreaming changes from your fork? If so, consider linking out to the upstream PR as well.

/ok-to-test

/cc @wlynch

[bigkevmcd]

@sbwsg gotcha...

Yes, forked version, the main changes landed, but while writing the tests for this, I added some extra test functionality (to the fake driver) jenkins-x/go-scm#67 which this relies on.

The main functionality landed in jenkins-x/go-scm#63

[tekton-robot]

@bigkevmcd: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-tekton-pipeline-build-tests	0a88aa7	link	/test pull-tekton-pipeline-build-tests
pull-tekton-pipeline-integration-tests	0a88aa7	link	/test pull-tekton-pipeline-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.