-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jnr-posix-api
plugin
#287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/test/java/org/datadog/jenkins/plugins/datadog/listeners/DatadogBuildListenerIT.java
Show resolved
Hide resolved
BTW |
What does this PR do?
Adds jnr-posix-api as a dependency to the plugin and bump the minimum required jenkins version
Description of the Change
Jenkins core removed JNR, and the java dogstatsd client relies on this library. To add the plugin, we need to bump the minimum required jenkins version.
Addresses #285
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
The name of the built-in node changed in more recent versions of jenkins, so we will have to update our tests in order to test them in our jenkinsfile: https://www.jenkins.io/changelog-stable/#v2.319.1
Release Notes
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.