Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jnr-posix-api plugin #287

Merged
merged 6 commits into from
Apr 8, 2022
Merged

Use jnr-posix-api plugin #287

merged 6 commits into from
Apr 8, 2022

Conversation

sarah-witt
Copy link
Collaborator

@sarah-witt sarah-witt commented Apr 8, 2022

What does this PR do?

Adds jnr-posix-api as a dependency to the plugin and bump the minimum required jenkins version

Description of the Change

Jenkins core removed JNR, and the java dogstatsd client relies on this library. To add the plugin, we need to bump the minimum required jenkins version.

Addresses #285

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

The name of the built-in node changed in more recent versions of jenkins, so we will have to update our tests in order to test them in our jenkinsfile: https://www.jenkins.io/changelog-stable/#v2.319.1

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@github-actions github-actions bot added the documentation Documentation related changes label Apr 8, 2022
@sarah-witt sarah-witt added the changelog/Changed Changed features results into a major version bump label Apr 8, 2022
@sarah-witt sarah-witt marked this pull request as ready for review April 8, 2022 15:36
Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarah-witt sarah-witt merged commit 96f2bee into master Apr 8, 2022
@sarah-witt sarah-witt deleted the sarah/add-posix-plugin branch April 8, 2022 19:25
@basil
Copy link
Member

basil commented Jul 29, 2022

BTW jnr-posix-api is part of the BOM as of https://github.com/jenkinsci/bom/releases/tag/1556.vfc6a_f216e3c6, so once you upgrade to that BOM version (which also requires upgrading to a baseline of 2.319.1 or later) you can remove the <version> from jnr-posix-api and get the version from the BOM instead, which should simplify maintenance.

@sarah-witt
Copy link
Collaborator Author

Thanks for the info @basil! We are going to bump the baseline with this PR so I will make note to do this after that PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backward-incompatible Warns for backward incompatible changes changelog/Changed Changed features results into a major version bump documentation Documentation related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants