Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x][Test Fix] Disconnecting worker when the test finishes #291

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

drodriguezhdez
Copy link
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

This PR is a fix for a test that checks the hostname. Depending on the node that executed the pipeline, the hostname is null or none. Apparently, the test is executed by other workers created in different tests. The PR disconnects the created workers to fulfill the expected behavior in the test.

This started failing when the Jenkins version for integration tests was upgraded in this PR (#287)

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez changed the base branch from master to 3.x April 21, 2022 10:20
@drodriguezhdez drodriguezhdez force-pushed the drodriguezhdez/3.x_fix_tests_hostname branch from 5f3d063 to bf6a21c Compare April 21, 2022 10:20
@drodriguezhdez drodriguezhdez added the changelog/no-changelog Changes don't appear in changelog label Apr 21, 2022
@drodriguezhdez drodriguezhdez merged commit c2df54c into 3.x Apr 22, 2022
@drodriguezhdez drodriguezhdez deleted the drodriguezhdez/3.x_fix_tests_hostname branch April 22, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog Changes don't appear in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants