[JENKINS-47167] - Handle null build when serializing the object to the disk, patch FindBugs #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e disk, patch FindBugs FindBugs was using the default “Medium” threshold, and hence it was missing some NPE risks. The change improves diagnostics for JENKINS-47167 and cleanups some other code bits
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
@reviewbybees done |
oleg-nenashev
added a commit
to oleg-nenashev/plugin-pom
that referenced
this pull request
Oct 26, 2017
This change makes the default configuration of FindBugs much more paranoid. On the Low level there are many Not-important issues, but experience of jenkinsci/envinject-lib#13 shows that otherwise we may miss real NPE risks in Jenkins.
oleg-nenashev
added a commit
to jenkinsci/plugin-pom
that referenced
this pull request
Dec 7, 2017
* Enable the max effort and low threshold by default. This change makes the default configuration of FindBugs much more paranoid. On the Low level there are many Not-important issues, but experience of jenkinsci/envinject-lib#13 shows that otherwise we may miss real NPE risks in Jenkins. * Revert the default FindBugs settings to the POM 2.x behavior, but make it configurable * Fix typo in the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindBugs was using the default “Medium” threshold, and hence it was missing some NPE risks.
The change improves diagnostics for JENKINS-47167 and cleanups some other code bits
https://issues.jenkins-ci.org/browse/JENKINS-47167
@reviewbybees