Skip to content

Commit

Permalink
Enable the max effort and low threshold by default.
Browse files Browse the repository at this point in the history
This change makes the default configuration of FindBugs much more paranoid.
On the Low level there are many Not-important issues, but experience of jenkinsci/envinject-lib#13 shows that otherwise we may miss real NPE risks in Jenkins.
  • Loading branch information
oleg-nenashev committed Oct 26, 2017
1 parent 9d1a359 commit 4692ed8
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@
<!-- Whether the build should fail if findbugs finds any error. -->
<!-- It is strongly encouraged to leave it as true. Use false with care only in transient situations. -->
<findbugs.failOnError>true</findbugs.failOnError>
<!-- Defines a default FindBugs threshold. -->
<!-- In Plugin POM 2.x the default value was Medium, but it was not enough to discover some null handling cases -->
<findbugs.threshold>Low</findbugs.threshold>

<!-- Whether to skip tests during release phase (they are executed in the prepare phase). -->
<release.skipTests>true</release.skipTests>
<!-- By default we do not create *-tests.jar. Set to false to allow other plugins to depend on test utilities in yours, using <classifier>tests</classifier>. -->
Expand Down Expand Up @@ -566,6 +570,8 @@
<!-- Instead we configure this in a profile -->
<xmlOutput>true</xmlOutput>
<findbugsXmlOutput>false</findbugsXmlOutput>
<effort>Max</effort>
<threshold>${findbugs.threshold}</threshold>
</configuration>
</execution>
</executions>
Expand Down

0 comments on commit 4692ed8

Please sign in to comment.