Update to extra-enforcer-rules with JDK 11 support #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batmat
added a commit
to batmat/git-plugin
that referenced
this pull request
Dec 1, 2018
Please do not merge
|
Something is wrong with our CI instance. This build and the downstream reference impls just hang in the queue |
|
PR build retriggered, now green. |
oleg-nenashev
approved these changes
Dec 2, 2018
There was a problem hiding this comment.
Just to be clear, it becomes an issue if and only if the source level is set to Java 11 (should be supported in this patch: #133). But it is nice to have the update in place in any case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jenkinsci/java11-support
Full diff of the updated dependency: mojohaus/extra-enforcer-rules@extra-enforcer-rules-1.0-beta-4...extra-enforcer-rules-1.1
✔️ Tested successfully in real conditions on the git-plugin. in jenkinsci/git-plugin#639