Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-54828] - Support building plugins with java.level=11 #133

Closed
wants to merge 4 commits into from

Conversation

oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev commented Nov 23, 2018

WiP version of the java.level=11 support for building plugins. So far it does not quite work.

Upstream deps/issues:

@jenkinsci/java11-support

pom.xml Outdated Show resolved Hide resolved
@batmat
Copy link
Member

batmat commented Dec 5, 2018

@oleg-nenashev conflicting now #134 was merged FYI.

Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the need for 1.${java.level} but it might because confusing at some point.. I guess we have no choice but to keep it that way.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@t-8ch
Copy link

t-8ch commented May 9, 2019

ASM 7.0 (and 7.1) have been released by now.

@jglick
Copy link
Member

jglick commented May 24, 2019

This seems to have been abandoned. Anyway has it not been superseded by other work?

@oleg-nenashev
Copy link
Member Author

oleg-nenashev commented May 24, 2019 via email

<id>java-level-11</id>
<activation>
<property>
<name>java.level</name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can not activate properties like this. It requires you run maven with mvn -Djava.level=11 as it can only look at system properties - not properties defined in the <properties> section of the XML

Copy link
Member Author

@oleg-nenashev oleg-nenashev Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big concern for me (whatever works if it is theoretically supported)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is it doesn't work if you have a reactor with a mix of things - you need to move everything in one to java11 (the reactor may not be the parent and all the plugins could come from different repositories with different release cycles)

@jglick
Copy link
Member

jglick commented Dec 2, 2021

Seems to be abandoned.

@jglick jglick closed this Dec 2, 2021
@oleg-nenashev
Copy link
Member Author

Still relevant

@oleg-nenashev oleg-nenashev reopened this Feb 13, 2022
@jetersen
Copy link
Member

#478 might be more relevant? 😅

@oleg-nenashev
Copy link
Member Author

might be more relevant? 😅

Might be. AFAICT we still have no consensus

@timja
Copy link
Member

timja commented Feb 13, 2022

Might be. AFAICT we still have no consensus

I think we can just merge #478 as soon as core drops java 8.

@jglick
Copy link
Member

jglick commented Aug 9, 2022

This is obsolete.

@jglick jglick closed this Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants