Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set automatically -release flag to java.level when running JDK9+ #449

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Set automatically -release flag to java.level when running JDK9+ #449

merged 1 commit into from
Oct 12, 2021

Conversation

Vlatombe
Copy link
Member

This avoids linking against APIs not present in the configured
java.level

https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#release

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe Vlatombe changed the title Set automatically -release flag to java.level when running JDK9+ Set automatically -release flag to java.level when running JDK9+ Oct 11, 2021
aHenryJard
aHenryJard approved these changes Oct 12, 2021
View reviewed changes
Copy link

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@Vlatombe Vlatombe merged commit 25d0e46 into jenkinsci:master Oct 12, 2021
@Vlatombe Vlatombe deleted the compiler-release branch October 12, 2021 11:49
@jglick
Copy link
Member

jglick commented Oct 12, 2021

See also #133.

@basil basil mentioned this pull request Feb 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen approved these changes

@aHenryJard aHenryJard aHenryJard approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vlatombe @jglick @jetersen @aHenryJard @timja