Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable hover styling on tables within .content class by default #1295

Closed
admench opened this issue Oct 12, 2017 · 0 comments · Fixed by #1707
Closed

Disable hover styling on tables within .content class by default #1295

admench opened this issue Oct 12, 2017 · 0 comments · Fixed by #1707

Comments

@admench
Copy link

admench commented Oct 12, 2017

This is about Bulma.

Overview of the problem

This is about the Bulma CSS framework
I'm using Bulma version [0.6.0]

Description

Referencing #1236 - this issue of the table row :hover behaviour is also set as default to .table inside .content class elements. I propose that we remove this behaviour as default, inline with #1236 as it caught me out after upgrading bulma just to avoid this. Will submit a PR.

Expected behavior

When hovering on a table, by default nothing should happen, only if .is-hoverable is added should the visual state change.

Actual behavior

When interacting with a .table within .content the hover state is applied by default.
admench added a commit to admench/bulma that referenced this issue Oct 12, 2017
@admench
Disable table hover in .content jgthms#1295
ac5a743
andrewsosa pushed a commit to andrewsosa/bulma that referenced this issue Mar 7, 2018
@admench @andrewsosa
Disable table hover in .content jgthms#1295
db8c73c
andrewsosa pushed a commit to andrewsosa/bulma that referenced this issue Mar 7, 2018
@admench @andrewsosa
Disable table hover in .content jgthms#1295
822cb94
@andrewsosa andrewsosa mentioned this issue Mar 7, 2018
Merged
jgthms pushed a commit that referenced this issue Apr 8, 2018
@andrewsosa @jgthms
Disable table hover in .content by default [Fixes #1295] (#1707)
4f58990 
* Disable table hover in .content #1295

* Remove reference to table hover in elements/content docs. 

Remove unnecessary $content-table-row-hover-background-color variable from sass file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable table hover in .content by default [Fixes #1295] andrewsosa/bulma
1 participant
@admench