Disable table hover in .content by default [Fixes #1295] #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary $content-table-row-hover-background-color variable from sass file
|
Here's two GIFs comparing the changes: Current version
Pull request version
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of PR #1296, which is a bugfix to #1295. Same commits, only now I've rebased @admench's changes as requested.
Proposed solution
Uses @admench's changes, which removes the table's hover background as the default background on hover. Again, fixes #1295.
Tradeoffs
The downside is needing to explicitly mark
.contenttables as.is-hoverable, but the previous behavior was undocumented and had no way to disable within the framework.Testing Done
Used in a project I'm working on, hover effects went away.
Docs Update
It looks like the docs changed to uses JSON content files since this change was originally suggested, let me know if I've made a mistake in updating the docs.