Fixes #1992 - Disabled form elements hover state is overlapping, if control has add-ons elements #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- DO NOT REBUILD THE CSS OUTPUT IN YOUR PR --> <!-- Choose one of the following: --> This is a bugfix <!-- New feature? Update the CHANGELOG.md too, and eventually the Docs. --> <!-- Improvement? Explain how and why. --> <!-- Bugfix? Reference that issue as well. --> If a form field is disabled and that form field uses has add-on element ( has-addons ), hover state is overlapping to add-on element. ### Proposed solution <!-- Which specific problem does this PR solve and how? --> <!-- If it fixes a particular Issue, add "Fixes #ISSUE_NUMBER" in your title --> This solution excludes disabled form elements hover state which is used within has-addons fields wrapper. Fixes jgthms#1992 ### Tradeoffs <!-- What are the drawbacks of this solution? Are there alternative ones? --> <!-- Think of performance, build time, usability, complexity, coupling…) --> No tradeoffs. ### Testing Done I checkout out master and changed the lines.
…-ons elements If a form field is disabled and that form field uses has add-on element ( has-addons ), hover state is overlapping to add-on element.
|
There’s no change?? |
|
@jgthms one of animated gif shows overlapping 1px border; the other one is after the fix. |
|
No I mean there’s no code change? The “Changes” tab shows 0 additions and 0 deletions. |
…-ons elements If a form field is disabled and that form field uses has add-on element ( has-addons ), hover state is overlapping to add-on element.
|
@jgthms Oh, I am so sorry, I had pushed a reverted version mistakenly. Now it should be ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix
Disabled form elements hover state is overlapping if a control has add-ons elements
Proposed solution
This solution excludes disabled form elements hover state which is used within has-addons fields wrapper
Fixes #1992
Tradeoffs
No tradeoffs.
Testing Done
I checkout out master and changed the lines. Please see attached files
.fields.has-addons > .control > input : hover bug
.fields.has-addons > .control > input : hover fixes
example html structure