Disabled form elements hover state is overlapping, if control has add-ons elements #1992
Comments
kdrdgn
pushed a commit
to kdrdgn/bulma
that referenced
this issue
Jul 13, 2018
<!-- DO NOT REBUILD THE CSS OUTPUT IN YOUR PR --> <!-- Choose one of the following: --> This is a bugfix <!-- New feature? Update the CHANGELOG.md too, and eventually the Docs. --> <!-- Improvement? Explain how and why. --> <!-- Bugfix? Reference that issue as well. --> If a form field is disabled and that form field uses has add-on element ( has-addons ), hover state is overlapping to add-on element. ### Proposed solution <!-- Which specific problem does this PR solve and how? --> <!-- If it fixes a particular Issue, add "Fixes #ISSUE_NUMBER" in your title --> This solution excludes disabled form elements hover state which is used within has-addons fields wrapper. Fixes jgthms#1992 ### Tradeoffs <!-- What are the drawbacks of this solution? Are there alternative ones? --> <!-- Think of performance, build time, usability, complexity, coupling…) --> No tradeoffs. ### Testing Done I checkout out master and changed the lines.
jgthms
pushed a commit
that referenced
this issue
Jul 18, 2018
…ontrol has add-ons elements (#1993) * <!-- PLEASE READ THE FOLLOWING INSTRUCTIONS --> <!-- DO NOT REBUILD THE CSS OUTPUT IN YOUR PR --> <!-- Choose one of the following: --> This is a bugfix <!-- New feature? Update the CHANGELOG.md too, and eventually the Docs. --> <!-- Improvement? Explain how and why. --> <!-- Bugfix? Reference that issue as well. --> If a form field is disabled and that form field uses has add-on element ( has-addons ), hover state is overlapping to add-on element. ### Proposed solution <!-- Which specific problem does this PR solve and how? --> <!-- If it fixes a particular Issue, add "Fixes #ISSUE_NUMBER" in your title --> This solution excludes disabled form elements hover state which is used within has-addons fields wrapper. Fixes #1992 ### Tradeoffs <!-- What are the drawbacks of this solution? Are there alternative ones? --> <!-- Think of performance, build time, usability, complexity, coupling…) --> No tradeoffs. ### Testing Done I checkout out master and changed the lines. * Disabled form elements hover state is overlapping, if control has add-ons elements If a form field is disabled and that form field uses has add-on element ( has-addons ), hover state is overlapping to add-on element. * Disabled form elements hover state is overlapping, if control has add-ons elements If a form field is disabled and that form field uses has add-on element ( has-addons ), hover state is overlapping to add-on element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview of the problem
Description
If a form field is disabled and that form field uses has add-on element ( has-addons ), hover state is overlapping to add-on element.
Steps to Reproduce
Expected behaviour
Don't assign a z-index value to disabled input elements.
Actual behaviour
Hovered input elements z-index value has been changed, thus add-ons default borders are overlapped. ( z-index value is 2 on hover state )
The text was updated successfully, but these errors were encountered: