Skip to content

Commit

Permalink
<!-- PLEASE READ THE FOLLOWING INSTRUCTIONS -->
Browse files Browse the repository at this point in the history
<!-- DO NOT REBUILD THE CSS OUTPUT IN YOUR PR -->

<!-- Choose one of the following: -->
This is a bugfix
<!-- New feature? Update the CHANGELOG.md too, and eventually the Docs. -->
<!-- Improvement? Explain how and why. -->
<!-- Bugfix? Reference that issue as well. -->
If a form field is disabled and that form field uses has add-on element ( has-addons ), hover state is overlapping to add-on element.

### Proposed solution
<!-- Which specific problem does this PR solve and how?  -->
<!-- If it fixes a particular Issue, add "Fixes #ISSUE_NUMBER" in your title -->
This solution excludes disabled form elements hover state which is used within has-addons fields wrapper.
Fixes jgthms#1992

### Tradeoffs
<!-- What are the drawbacks of this solution? Are there alternative ones? -->
<!-- Think of performance, build time, usability, complexity, coupling…) -->
No tradeoffs.

### Testing Done
I checkout out master and changed the lines.
  • Loading branch information
tw-kdrdgn committed Jul 13, 2018
1 parent 5a47885 commit 7c99680
Showing 1 changed file with 11 additions and 10 deletions.
21 changes: 11 additions & 10 deletions sass/elements/form.sass
Original file line number Diff line number Diff line change
Expand Up @@ -449,16 +449,17 @@ $help-size: $size-small !default
.button,
.input,
.select select
&:hover,
&.is-hovered
z-index: 2
&:focus,
&.is-focused,
&:active,
&.is-active
z-index: 3
&:hover
z-index: 4
&:not([disabled])
&:hover,
&.is-hovered
z-index: 2
&:focus,
&.is-focused,
&:active,
&.is-active
z-index: 3
&:hover
z-index: 4
&.is-expanded
flex-grow: 1
&.has-addons-centered
Expand Down

0 comments on commit 7c99680

Please sign in to comment.