Skip to content

Commit

Permalink
Merge pull request #123 from jhudsl/cansavvy/check-fix
Browse files Browse the repository at this point in the history
  • Loading branch information
cansavvy committed Jan 31, 2024
2 parents 2e3e866 + 60a69ef commit 48e8c44
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 6 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: ottrpal
Title: Companion Tools for Open-Source Tools for Training Resources (OTTR)
Version: 1.2
Version: 1.2.1
Authors@R: c(
person("Candace", "Savonen", , c("cansav09@gmail.com","csavonen@fredhutch.org"), role = c("aut", "cre"),
comment = c(ORCID = "0000-0001-6331-7070")),
Expand Down
6 changes: 5 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@

# ottrpal 1.2
# ottrpal 1.2.1

* Fixed minor windows curl bug for CRAN compatibility

# ottrpal 1.2

* Has the ability to transfer notes from a Google slide to fill in the alternative text and captions for the images for `include_slide()`
* Can accommodate multiple css files https://github.com/jhudsl/ottrpal/pull/115
Expand Down
2 changes: 1 addition & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

0 errors | 0 warnings | 0 notes

* This is an update to add two features: the ability to sync google slide notes with figure captures and the ability to use multiple css files.
* This update allows for differential handling to help with the windows curl test failing
7 changes: 4 additions & 3 deletions tests/testthat/test-gs_download.R
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
testthat::test_that("Download a Slide ", {

if (.Platform$OS.type != "windows") {
output_dir = tempdir()
outfile = ottrpal::include_slide(
paste0("https://docs.google.com/presentation/d/",
"12DPZgPteQBwgal6kSPP58zhPhjZ7QSPZLe3NkA8M3eo/",
"edit#slide=id.gc87451c247_0_17"),
"https://docs.google.com/presentation/d/1-7UvgVq5tP1pasTEErUM3bJFH2fU_pilH6i6_81CCXU/edit#slide=id.p",
output_dir = output_dir,
overwrite = FALSE)
testthat::expect_true(file.exists(outfile))
bn = basename(outfile)
testthat::expect_true(
bn == "12DPZgPteQBwgal6kSPP58zhPhjZ7QSPZLe3NkA8M3eo_gc87451c247_0_17.png"
)
}
})

0 comments on commit 48e8c44

Please sign in to comment.