Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only download if not windows #123

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Only download if not windows #123

merged 4 commits into from
Jan 31, 2024

Conversation

cansavvy
Copy link
Contributor

@cansavvy cansavvy commented Jan 4, 2024

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Curl fails for windows sometimes and CRAN wants to take ottrpal down because of that although this isn't really our fault. So I'm just making it so that the test is only done if the operating system is not windows.

@cansavvy
Copy link
Contributor Author

cansavvy commented Jan 4, 2024

This is ready. But CRAN isn't taking submissions right now. So I'll have to retry on Jan 9th

@cansavvy cansavvy merged commit 48e8c44 into main Jan 31, 2024
4 checks passed
@cansavvy cansavvy deleted the cansavvy/check-fix branch January 31, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant