Remaining feature files count always shown as 0 in 1.4.1

[rc2201]

During the execution, the number of remaining feature files to be executed is always showing as 0 on console logs in release 1.4.1
I compared it with release 1.4.0 and it is working fine in that release.

PFA screenshot using both versions highlighting the issue.

[rc2201]

@ptrthomas
Update- This is happening when using -Dkarate.options

[ptrthomas]

most likely related to #2444

[dvargas46]

Looks like this issue may have actually been around for a while, but #2444 made it more apparent. It happens whenever the runner is configured to use 1 thread. In this case, it uses the SyncExecutorService for running scenarios, which is implemented to run everything in the main caller thread upon submitting the runtime. So every time it checks the list of remaining uncompleted runtimes, it already completed the last, giving 0 as the result.

[ptrthomas]

@dvargas46 really appreciate the analysis, perhaps we just skip printing that when thread count is 1

[dvargas46]

@ptrthomas yes, that would work. I was also thinking a way to fix it while retaining the current behavior could be to load the futures list first before submitting it all to the executor.

Either way should be fairly straight forward to implement. I can try it out and create a PR if that works.

[ptrthomas]

yes please go ahead @dvargas46