-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-Dkarate.options flag disables the parallel execution in 1.4.1 #2444
Comments
@bondar-artem thanks for the repro ! it would be good to confirm if I hope there are no concerns if the fix is for1.5.0 - which means Java 17 is a must. |
Thank you, Peter! Yeah looks like this workaround works! |
My team and I experienced this issue too. We use I think one possible solution could be to use a boxed integer for the thread count on Main without a default value. That way we could do a simple null check when it's parsed in the Runner to see if it was a supplied option or not, similar to the other options. I can test it out sometime and create a PR if it works out. |
@dvargas46 yes please do submit a PR this - thanks for the work on the other one I will merge when I get a chance |
fix thread count issue when using karate.options #2444
karate 1.5.0.RC3 including this fix is now available |
1.5.0 released |
Description:
When using a flag in the command line to run tests with a -Dkarate.options, it disables the parallel execution of the tests.
Project to reproduce: https://github.com/bondar-artem/karate-parallel-issue
Steps:
mvn clean test
. 5 tests executed in parallelmvn clean test "-Dkarate.options=classpath:examples/TestParallel.feature"
. Tests executed in a single threadThe text was updated successfully, but these errors were encountered: