Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #2333 #2428

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Fix issue #2333 #2428

merged 1 commit into from
Oct 28, 2023

Conversation

Songshen1996
Copy link
Contributor

@Songshen1996 Songshen1996 commented Oct 28, 2023 •
edited by ptrthomas
Loading

Description

Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

@Songshen1996 Songshen1996 changed the base branch from master to develop October 28, 2023 10:41
@ptrthomas
Copy link
Member

thanks for pointing to develop as per instructions, I've approved the build, lets see if it passes

@Songshen1996
Copy link
Contributor Author

Nice, the solution works😊

@ptrthomas ptrthomas merged commit 4ef7fb4 into karatelabs:develop Oct 28, 2023
3 checks passed
ptrthomas added a commit that referenced this pull request Nov 9, 2023
@ptrthomas
code cleanup after prs #2433 #2434 #2428
71b3140
@ptrthomas
Copy link
Member

@Songshen1996 just for your reference I refactored your code a little: 71b3140

thanks again for the contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Songshen1996 @ptrthomas