Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #2333 #2428

Merged
merged 1 commit into from
Oct 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,14 @@ public class ScenarioEngine {

protected JsEngine JS;

/**
* Return current JsEngine
* @return Js engine
*/
public JsEngine getJS() {
return JS;
}

public ScenarioEngine(Config config, ScenarioRuntime runtime, Map<String, Variable> vars, Logger logger) {
this.config = config;
this.runtime = runtime;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,13 @@ public Object newInstance(Value... args) {
for (int i = 0; i < newArgs.length; i++) {
newArgs[i] = JsValue.fromJava(args[i]);
}
return new JsValue(value.execute(newArgs)).value;
JsEngine je = ScenarioEngine.get().getJS(); // get JsEngine
Value wrappedWithParentheses = je.evalForValue(
"("
+ value.getSourceLocation().getCharacters()
+ ")"); // Evaluate '(function)' to get function value
// execute the function with arguments
return new JsValue(wrappedWithParentheses.execute(newArgs)).value;
}

}
Expand Down
18 changes: 18 additions & 0 deletions karate-e2e-tests/src/test/java/responseStatus/ExamplesTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package responseStatus;

import com.intuit.karate.Results;
import com.intuit.karate.Runner;
import static org.junit.jupiter.api.Assertions.*;
import org.junit.jupiter.api.Test;

public class ExamplesTest {
@Test
void testParallel() {
Results results = Runner.path("classpath:responseStatus")
.outputCucumberJson(true)
.outputHtmlReport(true)
.configDir("src/test/java/responseStatus")
.parallel(1);
assertEquals(0, results.getFailCount(), results.getErrorMessages());
}
}
16 changes: 16 additions & 0 deletions karate-e2e-tests/src/test/java/responseStatus/all.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
Feature: responseStatus variable tests
Scenario: config js test
Given url 'https://www.baidu.com'
When method GET
Then status 200

* print 'responseStatus: ' + responseStatus
* assert isResponseStatus200_config()

Scenario: call test
Given url 'https://www.baidu.com'
When method GET
Then status 200

* print 'responseStatus: ' + responseStatus
* assert isResponseStatus200_call()
15 changes: 15 additions & 0 deletions karate-e2e-tests/src/test/java/responseStatus/call-once.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#@ignore
Feature:: common setup

Scenario: common setup

* def isResponseStatus200_callOnce =
"""
function() {
if( responseStatus != 200){
karate.log("Retry since expectedStatus 200 != actual responseStatus: " + responseStatus);
return false;
}
return true;
}
"""
16 changes: 16 additions & 0 deletions karate-e2e-tests/src/test/java/responseStatus/call-single.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@

#@ignore
Feature:: common setup

Scenario: common setup

* def isResponseStatus200_callSingle =
"""
function() {
if( responseStatus != 200){
karate.log("Retry since expectedStatus 200 != actual responseStatus: " + responseStatus);
return false;
}
return true;
}
"""
15 changes: 15 additions & 0 deletions karate-e2e-tests/src/test/java/responseStatus/call.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#@ignore
Feature:: common setup

Scenario: common setup

* def isResponseStatus200_call =
"""
function() {
if( responseStatus != 200){
karate.log("Retry since expectedStatus 200 != actual responseStatus: " + responseStatus);
return false;
}
return true;
}
"""
33 changes: 33 additions & 0 deletions karate-e2e-tests/src/test/java/responseStatus/karate-config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
function fn() {
var env = karate.env; // get system property 'karate.env'
karate.log('karate.env system property was:', env);
if (!env) {
env = 'dev';
}
var config = {
env: env,
myVarName: 'someValue'
}
if (env == 'dev') {
// customize
// e.g. config.foo = 'bar';
} else if (env == 'e2e') {
// customize
}

console.log("HELLO WORLD");

config = karate.callSingle('classpath:responseStatus/call-single.feature', config);
config = karate.call('classpath:responseStatus/call.feature', config);

config.isResponseStatus200_config = function () {
console.log(Object.keys(this));
if (responseStatus != 200) {
karate.log("Retry since expectedStatus 200 != actual responseStatus: " + responseStatus);
return false;
}
return true;
}

return config;
}
48 changes: 48 additions & 0 deletions karate-e2e-tests/src/test/java/responseStatus/local.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
#This example is in its own file since it prevents all tests from reading responseStatus
Feature: responseStatus callOnce test

Background:

* def isResponseStatus200 =
"""
function() {
if( responseStatus != 200){
karate.log("Retry since expectedStatus 200 != actual responseStatus: " + responseStatus);
return false;
}
return true;
}
"""

# if comment out callOnce the local js test will pass

* callonce read('classpath:responseStatus/call-once.feature')




#########################
##### failing #####
#########################

Scenario: callOnce test


Given url 'https://www.google.com'
When method GET
Then status 200

* print 'responseStatus: ' + responseStatus
* assert isResponseStatus200_callOnce()


#fails from callOnce
Scenario: local js test


Given url 'https://www.google.com'
When method GET
Then status 200

* print 'responseStatus: ' + responseStatus
* assert isResponseStatus200()