Issue #381 - Fix the display of units for the constraint offset #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the item 4 is unrelated. My problem was that |
|
Tested with other units. My patch set the stepValue. One problem is with MKS the steps are 1000 (mm) while the Standard they are in 1 (mm). In "building US" the step is 25.4 (that's one inch in mm). I'm not sure what's the proper solution here. |
|
I believe this fix the problem in which constraint offset wouldn't work with non-metric units set (ie broken). But the deeper problem lies with the widget that only accept metric (mm). |
|
@kbwbe ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a draft:
QDoubleSpinBox- [ ] figure out how to not retrigger the solver at each keystroke (this cause a value update too)Disclaimer: I'm new to Python and FreeCAD code base.