Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with Azure Pipelines PAT Auth #3160

Merged
merged 13 commits into from
Jun 29, 2022
Merged

Fix issue with Azure Pipelines PAT Auth #3160

merged 13 commits into from
Jun 29, 2022

Conversation

raravena80
Copy link
Contributor

@raravena80 raravena80 commented Jun 12, 2022 •
edited
Loading

Fixes #3159

Signed-off-by: Ricardo Aravena raravena80@gmail.com

Fix issue with Azure Pipelines PAT Auth

Checklist

Fixes #3159

Relates to #

@raravena80
Fix issue with Azure Pipelines PAT Auth
7dcaff4 
Fixes kedacore#3159 

Signed-off-by: Ricardo Aravena <raravena80@gmail.com>
@raravena80 raravena80 requested a review from a team as a code owner June 12, 2022 18:03
@JorTurFer
Copy link
Member

JorTurFer commented Jun 12, 2022 •
edited by github-actions bot
Loading

/run-e2e azure-pipelines*
Update: You can check the progress here

@raravena80
Move to TrimSuffix to metadata parsing section
54d2a69 
Signed-off-by: Ricardo Aravena <raravena80@gmail.com>
@raravena80
Update CHANGELOG.md with fixes for kedacore#3159
ea0b6a2 
Signed-off-by: Ricardo Aravena <raravena80@gmail.com>
@raravena80
Minor fix to meta variable
b10d4c0 
Signed-off-by: Ricardo Aravena <raravena80@gmail.com>
@raravena80
tab vs spaces.
1606902 
Signed-off-by: Ricardo Aravena <raravena80@gmail.com>
@raravena80
Remove extra line for SetBasicAuth
a5dd83b 
Signed-off-by: Ricardo Aravena <raravena80@gmail.com>
@raravena80
Add test with PAT having a newline
8e5a803 
Signed-off-by: Ricardo Aravena <raravena80@gmail.com>
@raravena80
Update azure_pipelines_scaler_test.go
e574919 
Added more specific test to stub.

Signed-off-by: Ricardo Aravena <raravena80@gmail.com>
@raravena80
Update azure_pipelines_scaler_test.go
4654a35 
Parse the auth token from the http request header.

Signed-off-by: Ricardo Aravena <raravena80@gmail.com>
@raravena80
Update azure_pipelines_scaler_test.go
aeb85fa 
nit

Signed-off-by: Ricardo Aravena <raravena80@gmail.com>
@JorTurFer
Copy link
Member

Looking good. Please solve the conflicts 🙏
Then I'll trigger e2e tests and if they pass, the PR is ready.
Thanks for the contribution ❤️

@raravena80
Merge branch 'main' into patch-1
89cfbd0 
Signed-off-by: Ricardo Aravena <raravena80@gmail.com>
@raravena80
Update azure_pipelines_scaler_test.go
6dc2793 
Fix order of dependency inclusion (alphabetically)

Signed-off-by: Ricardo Aravena <raravena80@gmail.com>
@JorTurFer
Copy link
Member

JorTurFer commented Jun 28, 2022 •
edited by github-actions bot
Loading

/run-e2e azure-pipelines*
Update: You can check the progress here

@raravena80
Update CHANGELOG.md
cad3d60 
Signed-off-by: Ricardo Aravena <raravena80@gmail.com>
JorTurFer
JorTurFer approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🙇

@JorTurFer JorTurFer merged commit 20cacec into kedacore:main Jun 29, 2022
@raravena80 raravena80 deleted the patch-1 branch June 29, 2022 14:26
@raravena80
Copy link
Contributor Author

Thanks a lot! 🙇

Finally! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
skip-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Pipelines Scaled Object cannot reconcile due to wrong PAT config
2 participants
@raravena80 @JorTurFer