Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with Azure Pipelines PAT Auth #3160

Merged
merged 13 commits into from
Jun 29, 2022
Merged

Fix issue with Azure Pipelines PAT Auth #3160

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7dcaff4
Fix issue with Azure Pipelines PAT Auth
raravena80 Jun 12, 2022
54d2a69
Move to TrimSuffix to metadata parsing section
raravena80 Jun 15, 2022
ea0b6a2
Update CHANGELOG.md with fixes for #3159
raravena80 Jun 15, 2022
b10d4c0
Minor fix to meta variable
raravena80 Jun 15, 2022
1606902
tab vs spaces.
raravena80 Jun 15, 2022
a5dd83b
Remove extra line for SetBasicAuth
raravena80 Jun 16, 2022
8e5a803
Add test with PAT having a newline
raravena80 Jun 16, 2022
e574919
Update azure_pipelines_scaler_test.go
raravena80 Jun 27, 2022
4654a35
Update azure_pipelines_scaler_test.go
raravena80 Jun 28, 2022
aeb85fa
Update azure_pipelines_scaler_test.go
raravena80 Jun 28, 2022
89cfbd0
Merge branch 'main' into patch-1
raravena80 Jun 28, 2022
6dc2793
Update azure_pipelines_scaler_test.go
raravena80 Jun 28, 2022
cad3d60
Update CHANGELOG.md
raravena80 Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions pkg/scalers/azure_pipelines_scaler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ var testAzurePipelinesMetadata = []parseAzurePipelinesMetadataTestData{
// using triggerAuthentication
{"using triggerAuthentication", map[string]string{"poolID": "1", "targetPipelinesQueueLength": "1"}, false, testAzurePipelinesResolvedEnv, map[string]string{"organizationURL": "https://dev.azure.com/sample", "personalAccessToken": "sample"}},
// using triggerAuthentication with personalAccessToken terminating in newline
{"using triggerAuthentication with personalAccessToken terminating in newline", map[string]string{"poolID": "1", "targetPipelinesQueueLength": "1"}, false, testAzurePipelinesResolvedEnv, map[string]string{"organizationURL": "https://dev.azure.com/sample", "personalAccessToken": "sample\n"}},
{"using triggerAuthentication with personalAccessToken terminating in newline", map[string]string{"poolID": "1", "targetPipelinesQueueLength": "1"}, true, testAzurePipelinesResolvedEnv, map[string]string{"organizationURL": "https://dev.azure.com/sample", "personalAccessToken": "sample\n"}},
// missing organizationURL
{"missing organizationURL", map[string]string{"organizationURLFromEnv": "", "personalAccessTokenFromEnv": "sample", "poolID": "1", "targetPipelinesQueueLength": "1"}, true, testAzurePipelinesResolvedEnv, map[string]string{}},
// missing personalAccessToken
Expand All @@ -41,8 +41,13 @@ func TestParseAzurePipelinesMetadata(t *testing.T) {
for _, testData := range testAzurePipelinesMetadata {
t.Run(testData.testName, func(t *testing.T) {
var apiStub = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte(`{"count":1,"value":[{"id":1}]}`))
personalAccessToken := testData.authParams["personalAccessToken"]
if personalAccessToken != "" && personalAccessToken[len(personalAccessToken)-1:] == "\n" {
JorTurFer marked this conversation as resolved.
Show resolved Hide resolved
w.WriteHeader(http.StatusUnauthorized)
} else {
w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte(`{"count":1,"value":[{"id":1}]}`))
}
}))

// set urls into local stub only if they are already defined
Expand Down