External Scaler: Add tls options in TriggerAuth metadata #4407

dttung2905 · 2023-03-26T15:41:05Z

Hi team,
This PR will fix the issue #3565

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update the documentation on docs: Add doc changes for tls argument in external scaler keda-docs#1133
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates: #4549

pkg/scalers/external_scaler.go

JorTurFer · 2023-04-03T20:36:29Z

Hi @dttung2905
(Not pressure at all) Is this ready to review? I haven't done it yet because I have seen the WIP prefix but maybe it's ready and you are expecting the review

dttung2905 · 2023-04-03T23:22:49Z

Hi @JorTurFer , my bad on the misleading title. Yes, please help to give me some early feedback on my PR 😛

JorTurFer · 2023-04-03T23:34:31Z

Hi @JorTurFer , my bad on the misleading title. Yes, please help to give me some early feedback on my PR 😛

I'll check it tomorrow morning

JorTurFer

Looking good, I have left some inline comments.
Will you add and e2e test to check this feature?

pkg/scalers/external_scaler.go

JorTurFer

Looking good, nice job! Only small nits inline

pkg/scalers/external_scaler.go

pkg/util/tls_config_test.go

JorTurFer · 2023-04-24T18:27:28Z

/run-e2e
Update: You can check the progress here

JorTurFer · 2023-04-25T15:53:36Z

/run-e2e
Update: You can check the progress here

JorTurFer · 2023-05-09T19:06:41Z

/run-e2e
Update: You can check the progress here

JorTurFer · 2023-05-10T06:27:27Z

/run-e2e pulsar
Update: You can check the progress here

pkg/scalers/external_scaler.go

JorTurFer · 2023-05-17T08:13:03Z

/run-e2e
Update: You can check the progress here

zroubalik

@dttung2905 please let us know when is this ready for a review.

dttung2905 · 2023-05-17T15:52:07Z

@dttung2905 please let us know when is this ready for a review.

Hi @zroubalik , its ready for review 🙏

zroubalik

LGTM, great job, just a minor nit on deprecation issue.

pkg/scalers/external_scaler.go

JorTurFer · 2023-05-17T22:24:15Z

/run-e2e
Update: You can check the progress here

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

zroubalik · 2023-05-18T11:44:26Z

/run-e2e
Update: You can check the progress here

zroubalik

LGTM, great job!

dttung2905 requested a review from a team as a code owner March 26, 2023 15:41

semgrep-app bot reviewed Mar 26, 2023

View reviewed changes

pkg/scalers/external_scaler.go Outdated Show resolved Hide resolved

JorTurFer reviewed Apr 4, 2023

View reviewed changes

pkg/scalers/external_scaler.go Outdated Show resolved Hide resolved

pkg/scalers/external_scaler.go Outdated Show resolved Hide resolved

dttung2905 force-pushed the external-scaler-tls branch from 23bf0f7 to f662140 Compare April 22, 2023 06:58

JorTurFer reviewed Apr 24, 2023

View reviewed changes

pkg/scalers/external_scaler.go Outdated Show resolved Hide resolved

pkg/util/tls_config_test.go Outdated Show resolved Hide resolved

dttung2905 force-pushed the external-scaler-tls branch from cba5f5a to 378fa3b Compare April 25, 2023 14:36

dttung2905 force-pushed the external-scaler-tls branch from 2244321 to 28fc2b5 Compare April 30, 2023 10:21

dttung2905 force-pushed the external-scaler-tls branch from 28fc2b5 to 2cd91d2 Compare May 9, 2023 15:13

semgrep-app bot reviewed May 13, 2023

View reviewed changes

pkg/scalers/external_scaler.go Show resolved Hide resolved

dttung2905 force-pushed the external-scaler-tls branch 2 times, most recently from 20beacd to d2de7b6 Compare May 13, 2023 14:02

dttung2905 force-pushed the external-scaler-tls branch from d2de7b6 to 6a1aabe Compare May 17, 2023 10:55

dttung2905 mentioned this pull request May 17, 2023

docs: Add doc changes for tls argument in external scaler kedacore/keda-docs#1133

Merged

1 task

zroubalik reviewed May 17, 2023

View reviewed changes

dttung2905 changed the title ~~WIP: Add tls options in TriggerAuth metadata~~ Add tls options in TriggerAuth metadata May 17, 2023

zroubalik approved these changes May 17, 2023

View reviewed changes

pkg/scalers/external_scaler.go Outdated Show resolved Hide resolved

dttung2905 mentioned this pull request May 18, 2023

Deprecate tlsCertFile in external scaler in favour of mor fine-grained config #4549

Closed

dttung2905 added 3 commits May 18, 2023 19:10

Add tls options in TriggerAuth metadata

5e92fa3

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

Fix semgrep

d1d9564

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

Add insecureSkipVerify config in ScaleObject

28f4528

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

dttung2905 added 13 commits May 18, 2023 19:10

Fix precommit CI check

25b747c

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

Refactor code to use tls util helper function

13f32a0

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

Add test for the new function in tls package

42af24d

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

Fix minor typo and CI failure from code review

1bb11e2

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

Fix static check CI failure

fd537d2

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

Fix failing unittest

0f18725

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

revert the method to check for CA

83f6570

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

Fix semgrep

c6a4268

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

dummy commit to trigger CI build

5f8fa08

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

Set ignore semgrep

3e6d4a4

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

Add CHANGELOG file

35dcbef

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

Change the argument name to

6ffa49d

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

Link deprecation comment to an issue

2af0f96

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

dttung2905 force-pushed the external-scaler-tls branch from 99ce5e4 to 2af0f96 Compare May 18, 2023 11:11

zroubalik approved these changes May 18, 2023

View reviewed changes

zroubalik changed the title ~~Add tls options in TriggerAuth metadata~~ External Scaler: Add tls options in TriggerAuth metadata May 18, 2023

zroubalik merged commit dcfcddc into kedacore:main May 18, 2023

zroubalik mentioned this pull request May 22, 2023

Extend TLS support for external scaler #3565

Closed

wsugarman mentioned this pull request Jul 30, 2023

Cannot Provide Both TLS CA Cert and Client Cert for KEDA Deployment kedacore/charts#503

Closed

JorTurFer mentioned this pull request Oct 16, 2023

fix: External Scalers docs explain correctly the parameters kedacore/keda-docs#1248

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

External Scaler: Add tls options in TriggerAuth metadata #4407

External Scaler: Add tls options in TriggerAuth metadata #4407

dttung2905 commented Mar 26, 2023 •

edited by zroubalik

Loading

JorTurFer commented Apr 3, 2023

dttung2905 commented Apr 3, 2023

JorTurFer commented Apr 3, 2023

JorTurFer left a comment

JorTurFer left a comment •

edited

Loading

JorTurFer commented Apr 24, 2023 •

edited by github-actions bot

Loading

JorTurFer commented Apr 25, 2023 •

edited by github-actions bot

Loading

JorTurFer commented May 9, 2023 •

edited by github-actions bot

Loading

JorTurFer commented May 10, 2023 •

edited by github-actions bot

Loading

JorTurFer commented May 17, 2023 •

edited by github-actions bot

Loading

zroubalik left a comment

dttung2905 commented May 17, 2023

zroubalik left a comment

JorTurFer commented May 17, 2023 •

edited by github-actions bot

Loading

zroubalik commented May 18, 2023 •

edited by github-actions bot

Loading

zroubalik left a comment

External Scaler: Add tls options in TriggerAuth metadata #4407

External Scaler: Add tls options in TriggerAuth metadata #4407

Conversation

dttung2905 commented Mar 26, 2023 • edited by zroubalik Loading

Checklist

JorTurFer commented Apr 3, 2023

dttung2905 commented Apr 3, 2023

JorTurFer commented Apr 3, 2023

JorTurFer left a comment

Choose a reason for hiding this comment

JorTurFer left a comment • edited Loading

Choose a reason for hiding this comment

JorTurFer commented Apr 24, 2023 • edited by github-actions bot Loading

JorTurFer commented Apr 25, 2023 • edited by github-actions bot Loading

JorTurFer commented May 9, 2023 • edited by github-actions bot Loading

JorTurFer commented May 10, 2023 • edited by github-actions bot Loading

JorTurFer commented May 17, 2023 • edited by github-actions bot Loading

zroubalik left a comment

Choose a reason for hiding this comment

dttung2905 commented May 17, 2023

zroubalik left a comment

Choose a reason for hiding this comment

JorTurFer commented May 17, 2023 • edited by github-actions bot Loading

zroubalik commented May 18, 2023 • edited by github-actions bot Loading

zroubalik left a comment

Choose a reason for hiding this comment

dttung2905 commented Mar 26, 2023 •

edited by zroubalik

Loading

JorTurFer left a comment •

edited

Loading

JorTurFer commented Apr 24, 2023 •

edited by github-actions bot

Loading

JorTurFer commented Apr 25, 2023 •

edited by github-actions bot

Loading

JorTurFer commented May 9, 2023 •

edited by github-actions bot

Loading

JorTurFer commented May 10, 2023 •

edited by github-actions bot

Loading

JorTurFer commented May 17, 2023 •

edited by github-actions bot

Loading

JorTurFer commented May 17, 2023 •

edited by github-actions bot

Loading

zroubalik commented May 18, 2023 •

edited by github-actions bot

Loading