Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to React 18 #1762

Open
sjd78 opened this issue Mar 12, 2024 · 2 comments
Open

Upgrade to React 18 #1762

sjd78 opened this issue Mar 12, 2024 · 2 comments
Assignees
@sjd78
Labels
kind/dependency-change Categorizes issue or PR as related to changing dependencies priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.6.0

Comments

@sjd78
Copy link
Member

sjd78 commented Mar 12, 2024

The current UI is running on React 17.

Now that react 18 is 2 years old, and that I've seen some libraries have a react dependency react@^18, upgrading UI should be done.

React 18 upgrade guide
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 12, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Mar 12, 2024
@sjd78 sjd78 added kind/dependency-change Categorizes issue or PR as related to changing dependencies and removed needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. labels Mar 12, 2024
@sjd78
Copy link
Member Author

sjd78 commented Mar 26, 2024 •
edited
Loading

Also upgrade for dev:

  • @hot-loader/react-dom
  • @pmmmwh/react-refresh-webpack-plugin
  • webpack-dev-server

Also upgrade in general:

  • react-hook-form
  • react-markdown
  • react-monaco-editor
  • react-router-dom

Related upgrade for i18n:

  • i18next
  • i18next-http-backend
  • react-i18next
  • i18next-parser
  • jq '.scripts.extract' client/package.json
  • client/public/locales/*/translations.json

@sjd78 sjd78 mentioned this issue Mar 27, 2024
Merged
sjd78 added a commit that referenced this issue Apr 3, 2024
@sjd78
👻 Update client dependencies (#1801)
14f4fc6 
Update mostly webpack related client dependencies to current versions.

This will handle the npm install warning about "stable" and the build
time warnings about updating "caniuse".

Other libraries will need more attention to be updated:
  - react@18 (see #1762)
  - i18next@latest (translation file changes around singular/plural)
  - msw@2 (APIs changed)
  - webpack-dev-server@5 (APIs changed)
  - `@testing-library@latest`
  - axios@latest

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 18, 2024
@sjd78
👻 Update client dependencies (konveyor#1801)
4a59778 
Resolves: https://issues.redhat.com/browse/MTA-2492

Update mostly webpack related client dependencies to current versions.

This will handle the npm install warning about "stable" and the build
time warnings about updating "caniuse".

Other libraries will need more attention to be updated:
  - react@18 (see konveyor#1762)
  - i18next@latest (translation file changes around singular/plural)
  - msw@2 (APIs changed)
  - webpack-dev-server@5 (APIs changed)
  - `@testing-library@latest`
  - axios@latest

Backport-of: konveyor#1801
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@sjd78 sjd78 mentioned this issue Apr 18, 2024
Merged
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 18, 2024
@sjd78
👻 Update client dependencies (konveyor#1801)
6bf0f9f 
Resolves: https://issues.redhat.com/browse/MTA-2492

Update mostly webpack related client dependencies to current versions.

This will handle the npm install warning about "stable" and the build
time warnings about updating "caniuse".

Other libraries will need more attention to be updated:
  - react@18 (see konveyor#1762)
  - i18next@latest (translation file changes around singular/plural)
  - msw@2 (APIs changed)
  - webpack-dev-server@5 (APIs changed)
  - `@testing-library@latest`
  - axios@latest

Backport-of: konveyor#1801
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78 added a commit that referenced this issue Apr 19, 2024
@sjd78
👻 [backport release-0.3] Update client dependencies (#1801) (#1860)
4b293aa 
Resolves: https://issues.redhat.com/browse/MTA-2492

Update mostly webpack related client dependencies to current versions.

This will handle the npm install warning about "stable" and the build
time warnings about updating "caniuse".

Other libraries will need more attention to be updated:
  - react@18 (see #1762)
  - i18next@latest (translation file changes around singular/plural)
  - msw@2 (APIs changed)
  - webpack-dev-server@5 (APIs changed)
  - `@testing-library@latest`
  - axios@latest

Backport-of: #1801

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@sjd78 sjd78 added this to the v0.5.0 milestone Apr 23, 2024
@sjd78 sjd78 added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/normal Higher priority than priority/minor. Nice to have. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Apr 23, 2024
@sjd78 sjd78 modified the milestones: v0.5.0, Next Jun 17, 2024
@sjd78 sjd78 modified the milestones: Next, v0.6.0 Aug 12, 2024
@sjd78 sjd78 self-assigned this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjd78 sjd78

Labels
kind/dependency-change Categorizes issue or PR as related to changing dependencies priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: 🔖 Ready
Milestone
v0.6.0
Development

No branches or pull requests
1 participant
@sjd78