Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify application table to better accommodate language discovery and task management #1934

Closed
sjd78 opened this issue Jun 3, 2024 · 10 comments · Fixed by #1985
Closed

Modify application table to better accommodate language discovery and task management #1934

sjd78 opened this issue Jun 3, 2024 · 10 comments · Fixed by #1985
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@sjd78
Copy link
Member

sjd78 commented Jun 3, 2024

Summary

With the addition of automatic language discovery, and general task management, the application table needs to be enhanced to give a good overview of an application's status across the various tasks.

Enhancement references:

Requirements

Base requirements:

  • Navigation to and the base functionality of the page and table remains the same (table rows, pagination, sorting, filtering, application bulk actions, application individual actions)
  • The all existing and new status columns are evaluated and refactored to allow easy future modification of the column data sources, calculations, and display
  • The new default set of the table columns fit into the horizontal space of a standard user's display (TODO: what is the screen size target?)

Existing columns modified and any new columns created that will provide insight to an application's:

  • assessment status (none, inherited, direct, overridden, ...)
  • review status (none, inherited, direct, overridden, ...)
  • analysis status (none, pending, running, success, fail, ...)
  • language discovery status (none, pending, running, success, fail, result, ...) ⇒ This column could take many forms and what is actually agreed and built will be decided in the near future. The issue will be updated then.

HUB enhancements that may be needed

  • Provide an "applications report" endpoint to align data sent to the UI for display with what the UI needs, and have the endpoint calculate status fields instead of replying on the UI to correlate a lot of data across multiple entities.

Mockups

(pending further discussions about content, look and feel)

@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 3, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jun 3, 2024
@sjd78
Copy link
Member Author

sjd78 commented Jun 4, 2024

@dymurray, @JustinXHale, @rromannissen, @jortel, @mansam -- for your consideration

Some of the details will change, but the overall structural work will remain consistent.

@sjd78 sjd78 added kind/feature Categorizes issue or PR as related to a new feature. priority/normal Higher priority than priority/minor. Nice to have. and removed needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jun 4, 2024
@sjd78 sjd78 added this to the v0.5.0 milestone Jun 4, 2024
@ibolton336
Copy link
Member

Does this cover any potential wizard changes as well?

@sjd78
Copy link
Member Author

sjd78 commented Jun 4, 2024

Does this cover any potential wizard changes as well?

I plan on writing another issue just for that change since that work can be done independently.

@sjd78 sjd78 changed the title [Enhancement] Modify application table to better accomodate language discovery and task management Modify application table to better accomodate language discovery and task management Jun 4, 2024
@sjd78 sjd78 added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 4, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 4, 2024
@jortel
Copy link
Contributor

jortel commented Jun 4, 2024

A technical change: When creating task resources.
When creating TaskGroup.Addon: analyzer replaced with TaskGroup.Kind: analyzer.

@sjd78
Copy link
Member Author

sjd78 commented Jun 4, 2024

To consider:

  • Find a superset of values for status states (all states?, assessment/review vs analysis). Potential base states:
    • None
    • Scheduled
    • Succeeded
    • InProgress
    • Failed
    • ...values for a state inherited from archetype
    • ...value for "analysis worked before but the latest run failed"
  • Consider actions that are enabled/disabled based on a status field → flip that over to the new status states from above

@sjd78 sjd78 changed the title Modify application table to better accomodate language discovery and task management Modify application table to better accommodate language discovery and task management Jun 5, 2024
@sjd78 sjd78 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/needs-information Indicates an issue needs more information in order to work on it. labels Jun 6, 2024
@sjd78
Copy link
Member Author

sjd78 commented Jun 24, 2024

A technical change: When creating task resources. When creating TaskGroup.Addon: analyzer replaced with TaskGroup.Kind: analyzer.

Handled in #1970 / #1971

@sjd78
Copy link
Member Author

sjd78 commented Jun 24, 2024

Does this cover any potential wizard changes as well?

I plan on writing another issue just for that change since that work can be done independently.

Handled in #1950

@sjd78 sjd78 self-assigned this Jun 25, 2024
@JustinXHale
Copy link
Member

Mocks. I would imagine that clicking the popover link takes you to a filter list in the task manager.

image
image

@sjd78
Copy link
Member Author

sjd78 commented Jun 27, 2024

Application icon statuses:

  • Running (InProgressIcon)
  • Success (CheckCircleIcon)
  • Failed (ExclamationCircleIcon)
  • Queued/Pending/In-flight (PendingIcon)
  • Canceled (TimesCircleIcon)
  • No Tasks (not sure on this icon, TaskIcon or UnknownIcon are potentials)

The icon will be driven off looking at the most recent task (by createTime) per kind for an application:

  • If there are no tasks for an application, show the application in No Tasks state
  • Else if any are "running", show the application in Running
  • Else if any are "queued", show the application in Queued state
  • Else if any are "failed", show the application as Failed
  • Else if any are "canceled", show the application as Canceled
  • Else if any are "success", show the application as Success

The popover will show the status per task kind and have a link to the task manager page with the application filter already applied.

ref @jortel , @dymurray , @rromannissen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants