Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Task creation and handling to prefer the kind field over the addon field #1970

Closed
sjd78 opened this issue Jun 20, 2024 · 1 comment · Fixed by #1971
Closed

Update Task creation and handling to prefer the kind field over the addon field #1970

sjd78 opened this issue Jun 20, 2024 · 1 comment · Fixed by #1971
Assignees
@sjd78
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.5.0

Comments

@sjd78
Copy link
Member

sjd78 commented Jun 20, 2024

Based on comments in #1950 and #1951, any of the UI code touching Tasks should prefer the use of kind over addon.

The application Analysis fields used to correlated to task by addon. This needs to be updated to correlate by kind == "analyzer" (when not blank) else fallback on addon == "analyzer". The fallback is needed to correlate tasks created in previous releases.

Originally posted by @jortel in #1950 (comment)
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 20, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jun 20, 2024
@sjd78 sjd78 mentioned this issue Jun 20, 2024
Closed
@sjd78 sjd78 added this to the v0.5.0 milestone Jun 20, 2024
@sjd78 sjd78 added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/normal Higher priority than priority/minor. Nice to have. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jun 20, 2024
@sjd78 sjd78 mentioned this issue Jun 20, 2024
Merged
sjd78 pushed a commit to sjd78/tackle2-ui that referenced this issue Jun 20, 2024
@ibolton336 @sjd78
🐛 Prefer Task field kind over addon
0e4967d 
Resolves: konveyor#1970

  - When creating a new `Taskgroup`, specify `kind` instead of
    `addon`

  - Process Tasks where `kind` may be missing and `addon` is given
    instead (tasks created before this change)

  - Make `Task.id` and `Taskgroup.id` required, `New<>` as needed

Signed-off-by: Ian Bolton <ibolton@redhat.com>
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@sjd78 sjd78 mentioned this issue Jun 20, 2024
Merged
@sjd78 sjd78 self-assigned this Jun 20, 2024
sjd78 pushed a commit to sjd78/tackle2-ui that referenced this issue Jun 20, 2024
@ibolton336 @sjd78
🐛 Prefer Task field kind over addon
3aea045 
Resolves: konveyor#1970

  - When creating a new `Taskgroup`, specify `kind` instead of
    `addon`

  - Process Tasks where `kind` may be missing and `addon` is given
    instead (tasks created before this change)

  - Make `Task.id` and `Taskgroup.id` required, `New<>` as needed

Signed-off-by: Ian Bolton <ibolton@redhat.com>
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@sjd78 sjd78 closed this as completed in 2bd0d6f Jun 20, 2024
@sjd78 sjd78 mentioned this issue Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjd78 sjd78

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.5.0
1 participant
@sjd78