Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify analysis wizard to accommodate language discovery #1950

Closed
sjd78 opened this issue Jun 10, 2024 · 3 comments · Fixed by #1951
Closed

Modify analysis wizard to accommodate language discovery #1950

sjd78 opened this issue Jun 10, 2024 · 3 comments · Fixed by #1951
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@sjd78
Copy link
Member

sjd78 commented Jun 10, 2024

Summary

With the addition of automatic language discovery, the analysis wizard target selection step needs to be enhanced.

Enhancement references:

Requirements

Base requirements:

  • Existing Wizard functionality remains the same
  • On the "Set targets" step:
    • The language selection box needs to be updated to dynamically source the option list, and the selected options
    • The language selection box needs to support an "All Language" and multiple selection of languages
    • The set of target cards displayed will continue to match the selections in the language box
    • Each target card will need a visual indicator of its language/provider
  • When creating the task resources, TaskGroup.Addon: analyzer needs to be replaced with TaskGroup.Kind: analyzer

Details on changes to the language selection box:

  • Provide a "(Show All)" option to display all targets regardless of language tags
  • Populate the options list from the Provider field of the fetched targets.
  • Initially select the languages based on the tags, of tag category "Language", across the applications selected for analysis.

Details on changes to the target cards:

  • Each target card should always display a label with it's provider. This will allow cards that belong to different providers to be differentiated when more than one language is selected.

HUB enhancements that may be needed:

None identified initially. Target data is already available. Tag category of "Language" is provided in the seed values. Applications already have their tag data provided.

Screen shots and mockups

Current State

image

Future State

(the only real difference will be he constant language/provider tag on the cards)

@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 10, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jun 10, 2024
@sjd78 sjd78 added this to the v0.5.0 milestone Jun 10, 2024
@sjd78 sjd78 added kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/normal Higher priority than priority/minor. Nice to have. and removed needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jun 10, 2024
@sjd78
Copy link
Member Author

sjd78 commented Jun 10, 2024

Note: Until language discovery is working consistently, we can manually tag a language to an application for testing purposes.

@jortel
Copy link
Contributor

jortel commented Jun 10, 2024

The application Analysis fields used to correlated to task by addon. This needs to be updated to correlate by kind == "analyzer" (when not blank) else fallback on addon == "analyzer". The fallback is needed to correlate tasks created in previous releases.

ibolton336 added a commit that referenced this issue Jun 20, 2024
Resolves #1950

UI Tests PR: 1136

Needs: konveyor/tackle-ui-tests#1136

Includes: 
- Provide a "(Show All)" option to display all targets regardless of
language tags. Adds a new component to handle this new menu type.
- Populate the options list from the Provider field of the fetched
targets.
- Initially select the languages based on the tags, of tag category
"Language", across the applications selected for analysis.
- Update TS type for Target to reflect the provider type changing to a
string[].
- Covers the hub change to the task model described here:
>The application Analysis fields used to correlated to task by addon.
This needs to be updated to correlate by kind == "analyzer" (when not
blank) else fallback on addon == "analyzer". The fallback is needed to
correlate tasks created in previous releases.
- Each target card should always display a label with it's provider.
This will allow cards that belong to different providers to be
differentiated when more than one language is selected.


<img width="1360" alt="Screenshot 2024-06-12 at 3 37 47 PM"
src="https://github.com/konveyor/tackle2-ui/assets/11218376/085de6c1-3b56-4532-ab38-81732da377e6">

---------

Signed-off-by: Ian Bolton <ibolton@redhat.com>
Co-authored-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants