✨ [AnalysisWizard] Language discovery changes #1951

ibolton336 · 2024-06-11T00:19:13Z

Resolves #1950

UI Tests PR: 1136

Includes:

Provide a "(Show All)" option to display all targets regardless of language tags. Adds a new component to handle this new menu type.
Populate the options list from the Provider field of the fetched targets.
Initially select the languages based on the tags, of tag category "Language", across the applications selected for analysis.
Update TS type for Target to reflect the provider type changing to a string[].
Covers the hub change to the task model described here:

The application Analysis fields used to correlated to task by addon. This needs to be updated to correlate by kind == "analyzer" (when not blank) else fallback on addon == "analyzer". The fallback is needed to correlate tasks created in previous releases.

Each target card should always display a label with it's provider. This will allow cards that belong to different providers to be differentiated when more than one language is selected.

codecov · 2024-06-11T00:25:31Z

Codecov Report

Attention: Patch coverage is 12.30769% with 57 lines in your changes missing coverage. Please review.

Project coverage is 42.73%. Comparing base (b654645) to head (cc9a731).
Report is 165 commits behind head on main.

Files	Patch %	Lines
client/src/app/components/SimpleSelectCheckbox.tsx	10.52%	34 Missing ⚠️
...pages/applications/analysis-wizard/set-targets.tsx	13.63%	19 Missing ⚠️
...ent/src/app/components/target-card/target-card.tsx	20.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1951      +/-   ##
==========================================
+ Coverage   39.20%   42.73%   +3.53%     
==========================================
  Files         146      166      +20     
  Lines        4857     5258     +401     
  Branches     1164     1299     +135     
==========================================
+ Hits         1904     2247     +343     
- Misses       2939     2995      +56     
- Partials       14       16       +2

Flag	Coverage Δ
client	`42.73% <12.30%> (+3.53%)`	⬆️
server	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

client/src/app/components/SimpleSelectCheckbox.tsx

client/src/app/pages/applications/analysis-wizard/set-targets.tsx

client/src/app/queries/tasks.ts

sjd78 · 2024-06-13T22:20:11Z

e2e ui testing is failing: https://github.com/konveyor/tackle2-ui/actions/runs/9504942845/job/26198861030?pr=1951#step:10:1822

sjd78

First look makes sense, but there is an inconsistency with the Target.provider field.

sjd78 · 2024-06-14T12:55:11Z

client/src/app/api/models.ts

@@ -425,7 +425,7 @@ export interface Target {
  labels?: TargetLabel[];
  image?: RulesetImage;
  ruleset: Ruleset;
-  provider?: string;
+  provider?: string[];


The provider is still a single string on the hub side: https://github.com/konveyor/tackle2-hub/blob/main/api/target.go#L242

Move to simple multi select menu in set targets step Drive target selection options from targets list Address missing checkbox on deselect Add provider to target card header Signed-off-by: Ian Bolton <ibolton@redhat.com>

Signed-off-by: Ian Bolton <ibolton@redhat.com>

ibolton336 · 2024-06-17T22:55:02Z

First look makes sense, but there is an inconsistency with the Target.provider field.

Fixed.

client/src/app/components/SimpleSelectCheckbox.tsx

client/src/app/pages/applications/analysis-wizard/set-targets.tsx

rszwajko

Looks good! I've found one bug during smoke tests:

filter by "Java" and select some cards
go back in the wizard
enter the target selection step again: filter is missing, cards cannot be de-selected

Signed-off-by: Ian Bolton <ibolton@redhat.com>

ibolton336 · 2024-06-18T18:51:27Z

Looks good! I've found one bug during smoke tests:

filter by "Java" and select some cards

go back in the wizard

enter the target selection step again: filter is missing, cards cannot be de-selected

Looks like this bug shows up as a result of introducing checkboxes for unselected cards:

    isSelectable={!!cardSelected}

I'd like to fix this in another issue if possible. Need to investigate the PF component. Reverted the change for now & #1252 will remain open.

rszwajko · 2024-06-19T18:44:48Z

@ibolton336
Integration tests are failing at selecting the card:

AssertionError: Timed out retrying after 8000ms: Expected to find element: `input[type="checkbox"]`, but never found it. Queried from:
              > cy.get(#target-card-Containerization)

ibolton336 · 2024-06-19T20:13:31Z

@ibolton336 Integration tests are failing at selecting the card:

AssertionError: Timed out retrying after 8000ms: Expected to find element: `input[type="checkbox"]`, but never found it. Queried from:
              > cy.get(#target-card-Containerization)

Fixed.

ibolton336 changed the title ~~[WIP] Add language options from tags~~ 🐛 [AnalysisWizard] Language discovery changes Jun 12, 2024

ibolton336 force-pushed the analysis-wizard-discovery branch 2 times, most recently from 6c07c23 to 8d20b5a Compare June 12, 2024 19:46

ibolton336 marked this pull request as ready for review June 12, 2024 19:48

ibolton336 requested review from sjd78 and rszwajko as code owners June 12, 2024 19:48

ibolton336 force-pushed the analysis-wizard-discovery branch from 8d20b5a to 9a17217 Compare June 12, 2024 19:48

rszwajko reviewed Jun 13, 2024

View reviewed changes

client/src/app/components/SimpleSelectCheckbox.tsx Outdated Show resolved Hide resolved

client/src/app/pages/applications/analysis-wizard/set-targets.tsx Outdated Show resolved Hide resolved

client/src/app/queries/tasks.ts Outdated Show resolved Hide resolved

ibolton336 force-pushed the analysis-wizard-discovery branch 2 times, most recently from 5111586 to 582c39e Compare June 13, 2024 18:32

sjd78 changed the title ~~🐛 [AnalysisWizard] Language discovery changes~~ ✨ [AnalysisWizard] Language discovery changes Jun 13, 2024

ibolton336 force-pushed the analysis-wizard-discovery branch from f30ac9a to b833c10 Compare June 13, 2024 22:26

sjd78 added this to the v0.5.0 milestone Jun 14, 2024

sjd78 reviewed Jun 15, 2024

View reviewed changes

ibolton336 force-pushed the analysis-wizard-discovery branch from 226a575 to 4cc1172 Compare June 17, 2024 14:33

Add language options from providers & select by app tags

22d308b

Move to simple multi select menu in set targets step Drive target selection options from targets list Address missing checkbox on deselect Add provider to target card header Signed-off-by: Ian Bolton <ibolton@redhat.com>

ibolton336 force-pushed the analysis-wizard-discovery branch from 4cc1172 to d26381d Compare June 17, 2024 14:33

ibolton336 mentioned this pull request Jun 17, 2024

✨ Support new dropdown for language select konveyor/tackle-ui-tests#1136

Merged

Fix broken QE selector

1e4f9ec

Signed-off-by: Ian Bolton <ibolton@redhat.com>

ibolton336 force-pushed the analysis-wizard-discovery branch from b9bf667 to 1e4f9ec Compare June 17, 2024 18:48

ibolton336 closed this Jun 17, 2024

ibolton336 reopened this Jun 17, 2024

ibolton336 closed this Jun 17, 2024

ibolton336 reopened this Jun 17, 2024

rszwajko reviewed Jun 18, 2024

View reviewed changes

client/src/app/components/SimpleSelectCheckbox.tsx Outdated Show resolved Hide resolved

client/src/app/pages/applications/analysis-wizard/set-targets.tsx Outdated Show resolved Hide resolved

rszwajko reviewed Jun 18, 2024

View reviewed changes

Revert isChecked change

765b264

Signed-off-by: Ian Bolton <ibolton@redhat.com>

ibolton336 force-pushed the analysis-wizard-discovery branch from ef73291 to 765b264 Compare June 18, 2024 18:49

Merge branch 'main' into analysis-wizard-discovery

cc9a731

ibolton336 closed this Jun 19, 2024

ibolton336 reopened this Jun 19, 2024

rszwajko self-requested a review June 20, 2024 13:08

rszwajko approved these changes Jun 20, 2024

View reviewed changes

ibolton336 merged commit ea2005b into konveyor:main Jun 20, 2024
22 of 23 checks passed

sjd78 mentioned this pull request Jun 20, 2024

Update Task creation and handling to prefer the kind field over the addon field #1970

Closed

This was referenced Jun 22, 2024

operator konveyor-operator (0.5.0-alpha.1) k8s-operatorhub/community-operators#4534

Merged

operator konveyor-operator (0.5.0-alpha.1) redhat-openshift-ecosystem/community-operators-prod#4700

Merged

ibolton336 mentioned this pull request Jul 24, 2024

🐛 Fix target card behavior and rendering #2025

Merged

This was referenced Jul 30, 2024

operator konveyor-operator (0.5.0) k8s-operatorhub/community-operators#4759

Merged

operator konveyor-operator (0.5.0) redhat-openshift-ecosystem/community-operators-prod#4884

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ [AnalysisWizard] Language discovery changes #1951

✨ [AnalysisWizard] Language discovery changes #1951

ibolton336 commented Jun 11, 2024 •

edited

Loading

codecov bot commented Jun 11, 2024 •

edited

Loading

sjd78 commented Jun 13, 2024

sjd78 left a comment

sjd78 Jun 14, 2024

ibolton336 commented Jun 17, 2024

rszwajko left a comment

ibolton336 commented Jun 18, 2024

rszwajko commented Jun 19, 2024

ibolton336 commented Jun 19, 2024

✨ [AnalysisWizard] Language discovery changes #1951

✨ [AnalysisWizard] Language discovery changes #1951

Conversation

ibolton336 commented Jun 11, 2024 • edited Loading

codecov bot commented Jun 11, 2024 • edited Loading

Codecov Report

sjd78 commented Jun 13, 2024

sjd78 left a comment

Choose a reason for hiding this comment

sjd78 Jun 14, 2024

Choose a reason for hiding this comment

ibolton336 commented Jun 17, 2024

rszwajko left a comment

Choose a reason for hiding this comment

ibolton336 commented Jun 18, 2024

rszwajko commented Jun 19, 2024

ibolton336 commented Jun 19, 2024

ibolton336 commented Jun 11, 2024 •

edited

Loading

codecov bot commented Jun 11, 2024 •

edited

Loading