👻 Refactor Dependencies details drawer layout and unique row handling #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
approved these changes
Nov 16, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1552 +/- ##
=======================================
Coverage 40.49% 40.49%
=======================================
Files 145 145
Lines 4638 4638
Branches 1087 1087
=======================================
Hits 1878 1878
Misses 2746 2746
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjd78
force-pushed
the
refactor_dep-drawer
branch
from
9137087
to
daf5b4f
Compare
Changes:
- Refactor the header and layout of tabs for the dependencies detail
drawer following the changes in konveyor#1542.
- Show the dependency name and provider in the header since those
two fields together are the row unique key
- Update the filter for the dependency applications to include both
the name and the provider to match the row unique key
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
force-pushed
the
refactor_dep-drawer
branch
from
daf5b4f
to
099fd76
Compare
sjd78
changed the title
|
Screenshot before: After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Refactor the header and layout of tabs for the dependencies detail drawer following the changes in 🐛 Fix header issue causing tabs to be hidden #1542.
Show the dependency name and provider in the header since those two fields together are the row unique key (see 🐛 Refactor dependencies, select row by name and provider #1554).
Update the filter for the dependency applications to include both the name and the provider to match the row unique key (see 🐛 Refactor dependencies, select row by name and provider #1554).