Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Fetch tasks with server-based filtering #1956

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

rszwajko
Copy link
Collaborator

Part-of: #1931
Reference-Url: konveyor/tackle2-hub#640

Part-of: konveyor#1931
Reference-Url: konveyor/tackle2-hub#640
Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 42.13%. Comparing base (b654645) to head (1dfdb51).
Report is 160 commits behind head on main.

Files Patch % Lines
client/src/app/queries/tasks.ts 25.00% 6 Missing ⚠️
client/src/app/api/rest.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1956      +/-   ##
==========================================
+ Coverage   39.20%   42.13%   +2.93%     
==========================================
  Files         146      166      +20     
  Lines        4857     5328     +471     
  Branches     1164     1294     +130     
==========================================
+ Hits         1904     2245     +341     
- Misses       2939     3067     +128     
- Partials       14       16       +2     
Flag Coverage Δ
client 42.13% <30.00%> (+2.93%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rszwajko rszwajko merged commit c2f4f06 into konveyor:main Jun 13, 2024
12 checks passed
sjd78 added a commit to sjd78/tackle2-ui that referenced this pull request Jun 14, 2024
Update the `Task` interface, and related, to follow
the current definitions of Task REST resource[1] on
the hub.

Supports: konveyor#1955, konveyor#1956, konveyor#1957

[1] - https://github.com/konveyor/tackle2-hub/blob/1366d95b62ac7717826fd9f64c9e268013107008/api/task.go#L725-L748

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78 added a commit to sjd78/tackle2-ui that referenced this pull request Jun 14, 2024
Update the `Task` interface, and related, to follow
the current definitions of Task REST resource[1] on
the hub.

Supports: konveyor#1955, konveyor#1956, konveyor#1957

[1] - https://github.com/konveyor/tackle2-hub/blob/1366d95b62ac7717826fd9f64c9e268013107008/api/task.go#L725-L748

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78 added a commit that referenced this pull request Jun 14, 2024
Update the `Task` interface, and related, to follow the current
definitions of Task REST resource[^1] on the hub.

Supports: #1955, #1956, #1957

[^1]:
https://github.com/konveyor/tackle2-hub/blob/1366d95b62ac7717826fd9f64c9e268013107008/api/task.go#L725-L748

---------

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants