Workaround for issue 65: Audio does not resume after it has been suspend... #68
Conversation
…ended by iOS (iPhone 5s & iOS 7.1) kstenerud#65
| @@ -218,7 +218,9 @@ - (void) setInterrupted:(bool) value | |||
| { | |||
| if(nil != suspendStatusChangeTarget) | |||
| { | |||
| objc_msgSend(suspendStatusChangeTarget, suspendStatusChangeSelector, interruptLock); | |||
| void (*suspendStatusChange)(id, SEL, bool); | |||
There was a problem hiding this comment.
Oh looks like bool is used all over the place. Is there a reason for this?
There was a problem hiding this comment.
bool is used all over OALSuspendHandler.m so I think it's reasonable to stick with that. If it's changed it should be changed everywhere.
There was a problem hiding this comment.
I used bool originally because it's part of the c99 spec.
There was a problem hiding this comment.
Yeah. ObjC allows either (they both resolve to the same type and value on all architectures).
If I were to do it over I'd use BOOL to stay with the established convention (which predates C99, when there was no official bool type). I think it's better to be consistent, and would rather switch everything from one convention to the other at once rather than piecemeal (for example, ObjectAL still uses the old style of naming ivars and declaring properties).
|
Looks good to me. |
Workaround for issue 65: Audio does not resume after it has been suspend...
Workaround for issue 65: Audio does not resume after it has been suspended by iOS (iPhone 5s & iOS 7.1)
#65