Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for issue 65: Audio does not resume after it has been suspend... #68

Merged
merged 1 commit into from
Jun 24, 2014
Merged

Workaround for issue 65: Audio does not resume after it has been suspend... #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ObjectAL/ObjectAL/Session/OALSuspendHandler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,9 @@ - (void) setInterrupted:(bool) value
{
if(nil != suspendStatusChangeTarget)
{
objc_msgSend(suspendStatusChangeTarget, suspendStatusChangeSelector, interruptLock);
void (*suspendStatusChange)(id, SEL, bool);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be BOOL.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh looks like bool is used all over the place. Is there a reason for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool is used all over OALSuspendHandler.m so I think it's reasonable to stick with that. If it's changed it should be changed everywhere.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used bool originally because it's part of the c99 spec.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is Objective-C?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. ObjC allows either (they both resolve to the same type and value on all architectures).
If I were to do it over I'd use BOOL to stay with the established convention (which predates C99, when there was no official bool type). I think it's better to be consistent, and would rather switch everything from one convention to the other at once rather than piecemeal (for example, ObjectAL still uses the old style of naming ivars and declaring properties).

suspendStatusChange = (void (*)(id, SEL, bool))[suspendStatusChangeTarget methodForSelector:suspendStatusChangeSelector];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

suspendStatusChange(suspendStatusChangeTarget, suspendStatusChangeSelector, interruptLock);
}
}
}
Expand Down