Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert tests to use gomega/ginkgo #454

Closed
cpanato opened this issue Mar 15, 2020 · 1 comment · Fixed by #465
Closed

Convert tests to use gomega/ginkgo #454

cpanato opened this issue Mar 15, 2020 · 1 comment · Fixed by #465
Assignees
@cpanato

Comments

@cpanato
Copy link
Member

cpanato commented Mar 15, 2020

In CAPI (see kubernetes-sigs/cluster-api#2433) we converted the tests to use the gomega/ginkgo.

I propose we do the same here to make it standard across CAPX

Already spoke with @CecileRobertMichon in Slack and she agree.
@cpanato
Copy link
Member Author

cpanato commented Mar 15, 2020

I can work on that 😄
/assign

This was referenced Mar 19, 2020
Merged
Merged
k8s-ci-robot added a commit that referenced this issue Mar 19, 2020
@k8s-ci-robot
Merge pull request #462 from cpanato/GH-454-api
61b6a1e 
🏃api/tests: standardize gomega usage
k8s-ci-robot added a commit that referenced this issue Mar 19, 2020
@k8s-ci-robot
Merge pull request #463 from cpanato/GH-454-cloud
d28e87b 
cloud/tests: standardize gomega usage
@cpanato cpanato mentioned this issue Mar 20, 2020
Merged
k8s-ci-robot added a commit that referenced this issue Mar 20, 2020
@k8s-ci-robot
Merge pull request #465 from cpanato/GH-454-controllers
0169342 
🏃controllers/tests: standardize gomega usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpanato cpanato

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🏃controllers/tests: standardize gomega usage cpanato/cluster-api-provider-azure
1 participant
@cpanato