Standardize gomega/ginkgo imports

[chuckha]

This issue is to standardize how to import ginkgo/gomega.

If we are using ginkgo/gomega in a test, it should be imported using the . import like this:

import (
    . "github.com/onsi/ginkgo"
    . "github.com/onsi/gomega"
)

The reason to do this is to provide a consistent feel across all ginkgo/gomega tests in the codebase.

/kind feature
/help
/milestone Next

[detiber]

There is at least one place where the gomega imports (when using .) conflict with functions defined (controlplane/kubeadm/internal).

I'd argue that we should prefer readability of shipped code paths over the readability of tests, so if we are not willing to make exceptions for tests that would test packages that may have conflicting naming to ginkgo/gomega, then I would suggest that we not use . imports for ginkgo/gomega and instead be explicit in our use of ginkgo/gomega (ginkgo.Eventually, gomega.Expect, etc).

[cpanato]

let me try this one
/assign

[cpanato]

for the existing tests that already have the . should we update to remove that?

[randomvariable]

probably.

assuming you've started on this, so will mark as
/lifecycle active

[vincepri]

for the existing tests that already have the . should we update to remove that?

apart from control plane one, let's try to use the dot import everywhere else and find a different solution there

[cpanato]

/remove-help