Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃cmd-clusterctl-client-cluster/tests: standardize gomega imports #2632

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 11, 2020

What this PR does / why we need it:
standardize gomega imports for cmd/clusterctl/client/cluster/** tests
will open other PR for the other folders to make easier the review

/cc @vincepri @detiber

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #2433

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2020
@cpanato cpanato changed the title 🏃cmd-clusterctl-client/tests: standardize gomega imports 🏃cmd-clusterctl-client-cluster/tests: standardize gomega imports Mar 11, 2020
cmd/clusterctl/client/cluster/components_test.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/installer_test.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/inventory_test.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/inventory_test.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/objectgraph_test.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/objectgraph_test.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/objectgraph_test.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/template_test.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/template_test.go Outdated Show resolved Hide resolved
@cpanato
Copy link
Member Author

cpanato commented Mar 11, 2020

thanks @detiber for your review! PTAL

@detiber
Copy link
Member

detiber commented Mar 11, 2020

/lgtm
/assign @vincepri

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2020
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/milestone v0.3.1

@k8s-ci-robot k8s-ci-robot added this to the v0.3.1 milestone Mar 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit bfcc6f3 into kubernetes-sigs:master Mar 11, 2020
@cpanato cpanato deleted the GH-2433-5 branch March 11, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants