Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏃 cmd-clusterctl-client/tests: standardize gomega imports #2645

Merged
merged 1 commit into from
Mar 16, 2020
Merged

🏃 cmd-clusterctl-client/tests: standardize gomega imports #2645

merged 1 commit into from
Mar 16, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 11, 2020

What this PR does / why we need it:
standardize gomega imports for cmd/clusterctl/client/* tests
will open other PR for the other folders to make easier the review

/cc @vincepri @detiber

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #2433

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2020
JoelSpeed
JoelSpeed reviewed Mar 12, 2020
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane once @detiber's comments are fixed. I added a couple of suggestions to improve the code while you're here, though I realise you didn't add the TODOs I've suggested to fix so feel free to ignore

cmd/clusterctl/client/delete_test.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/upgrade_test.go Outdated Show resolved Hide resolved
@fabriziopandini
Copy link
Member

/hold
As far as I understand the issue, the request was to standardize existing ginko/gomega imports, not to convert everything to use ginko/gomega
@chuckha @vincepri ^^

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2020
@fabriziopandini
Copy link
Member

/hold cancel
👀 doing review now

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2020
fabriziopandini
fabriziopandini reviewed Mar 13, 2020
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato thanks for stepping up for this effort!

cmd/clusterctl/client/common_test.go Show resolved Hide resolved
cmd/clusterctl/client/config_test.go Show resolved Hide resolved
cmd/clusterctl/client/config_test.go Show resolved Hide resolved
cmd/clusterctl/client/config_test.go Show resolved Hide resolved
cmd/clusterctl/client/config_test.go Show resolved Hide resolved
cmd/clusterctl/client/delete_test.go Show resolved Hide resolved
cmd/clusterctl/client/init_test.go Show resolved Hide resolved
cmd/clusterctl/client/init_test.go Show resolved Hide resolved
cmd/clusterctl/client/upgrade_test.go Show resolved Hide resolved
cmd/clusterctl/client/upgrade_test.go Show resolved Hide resolved
@cpanato
Copy link
Member Author

cpanato commented Mar 13, 2020

@fabriziopandini done, thanks for your review. PTAL

@fabriziopandini
Copy link
Member

looks great!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2020
vincepri
vincepri approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/milestone v0.3.1

@k8s-ci-robot k8s-ci-robot added this to the v0.3.1 milestone Mar 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 411cfbd into kubernetes-sigs:master Mar 16, 2020
@cpanato cpanato deleted the GH-2433-8 branch March 16, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detiber detiber detiber left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

@vincepri vincepri vincepri approved these changes

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.1
Development

Successfully merging this pull request may close these issues.
6 participants
@cpanato @fabriziopandini @k8s-ci-robot @detiber @vincepri @JoelSpeed